Differences between revisions 9 and 10
⇤ ← Revision 9 as of 2008-08-28 11:50:52 →
Size: 2403
Editor: EldZierau
Comment:
← Revision 10 as of 2010-08-16 10:24:31 → ⇥
Size: 2414
Editor: localhost
Comment: converted to 1.6 markup
Deletions are marked like this. Additions are marked like this.
Line 5: Line 5:
<See [:Code Review Process#CodeReviewOverview:Code Review Overview per Iteration] for description of how to name use this template.> <See [[Code Review Process#CodeReviewOverview|Code Review Overview per Iteration]] for description of how to name use this template.>
Line 13: Line 13:
For details on how to do a review, see [:Code_Review_Process:Code Review Process].
||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Class/Page]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Version]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Lines/parts]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Task]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Author(s)]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Reviewer(s)]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Review date]''' ||<bgcolor="#dddddd">'''[:Code Review Process#TableFilledReviewsOverview:Follow-up]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Done]''' ||
|| <Link to code review page for class/JSP-page named with java path name, f.ex. dk.netarkivet.harvestdefinition.JobDAO> || <SVN version of code being reviewed> || <Lines/parts to review> || <Reference to task caused the code changes that are being reviewed as for example a bugs, a feature request or an assignment> || <Initials of author of changes in code> || <Initials of reviewer in code review> || <Date that review was held on form YYYY/MM/DD> || <Initials of person to do follow-up on code review> || <Must be either [[BR]] '''''Ok''''' (no further action), [[BR]] '''''Ok w/postponed''''' (no further action within this iteration, but includes postpones to be done later)> ||		 For details on how to do a review, see [[Code_Review_Process|Code Review Process]].
||<bgcolor="#dddddd" style="text-align: center;">'''[[Code Review Process#TableFilledReviewsOverview|Class/Page]]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[[Code Review Process#TableFilledReviewsOverview|Version]]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[[Code Review Process#TableFilledReviewsOverview|Lines/parts]]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[[Code Review Process#TableFilledReviewsOverview|Task]]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[[Code Review Process#TableFilledReviewsOverview|Author(s)]]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[[Code Review Process#TableFilledReviewsOverview|Reviewer(s)]]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[[Code Review Process#TableFilledReviewsOverview|Review date]]''' ||<bgcolor="#dddddd">'''[[Code Review Process#TableFilledReviewsOverview|Follow-up]]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[[Code Review Process#TableFilledReviewsOverview|Done]]''' ||
|| <Link to code review page for class/JSP-page named with java path name, f.ex. dk.netarkivet.harvestdefinition.JobDAO> || <SVN version of code being reviewed> || <Lines/parts to review> || <Reference to task caused the code changes that are being reviewed as for example a bugs, a feature request or an assignment> || <Initials of author of changes in code> || <Initials of reviewer in code review> || <Date that review was held on form YYYY/MM/DD> || <Initials of person to do follow-up on code review> || <Must be either <<BR>> '''''Ok''''' (no further action), <<BR>> '''''Ok w/postponed''''' (no further action within this iteration, but includes postpones to be done later)> ||

Code Reviews in Iteration <XX>

<See Code Review Overview per Iteration for description of how to name use this template.>

Review of code should happen immediately after coding for a task or bug is done, so as little as possible is based on unreviewed code.

If the reviewer for some reason cannot be contacted within a reasonable timeframe, another reviewer should be chosen.

We don't register review time as separate from coding time.

For details on how to do a review, see Code Review Process.

Class/Page

Version

Lines/parts

Task

Author(s)

Reviewer(s)

Review date

Follow-up

Done

<Link to code review page for class/JSP-page named with java path name, f.ex. dk.netarkivet.harvestdefinition.JobDAO>

<SVN version of code being reviewed>

<Lines/parts to review>

<Reference to task caused the code changes that are being reviewed as for example a bugs, a feature request or an assignment>

<Initials of author of changes in code>

<Initials of reviewer in code review>

<Date that review was held on form YYYY/MM/DD>

<Initials of person to do follow-up on code review>

<Must be either
Ok (no further action),
Ok w/postponed (no further action within this iteration, but includes postpones to be done later)>

CodeReviewOverviewPageTemplate (last edited 2010-08-16 10:24:31 by localhost)