Differences between revisions 1 and 2

Reviews in iteration XX

Review of code should happen immediately after coding for a task or bug is done, so as little as possible is based on unreviewed code.

If the reviewer for some reason cannot be contacted within a reasonable timeframe, another reviewer should be chosen.

We don't register review time as separate from coding time.

For details on how to do a review, see [Code_Review_Process].

[:Code Review Process#TableFilledReviewsOverview:Class/Page]	[:Code Review Process#TableFilledReviewsOverview:Version]	[:Code Review Process#TableFilledReviewsOverview:Parts/lines]	[:Code Review Process#TableFilledReviewsOverview:Task]	[:Code Review Process#TableFilledReviewsOverview:Author(s)]	[:Code Review Process#TableFilledReviewsOverview:Reviewer(s)]	[:Code Review Process#TableFilledReviewsOverview:Review date]	[:Code Review Process#TableFilledReviewsOverview:Follow-up]	[:Code Review Process#TableFilledReviewsOverview:Done]
<Link to code review page for class/JSP-page named with java path name, f.ex. dk.netarkivet.harvestdefinition.JobDAO>	<SVN version of code being reviewed>	<Lines/parts to review>	<Reference to task caused the code changes that are being reviewed as for example a bugs, a feature request or an assignment>	<Initials of author of changes in code>	<Initials of reviewer in code review>	<Date that review was held on form YYYY/MM/DD>	<Initials of person to do follow-up on code review>	<Must be either BR Ok (no further action), BR Ok w/postponed (no further action within this iteration, but includes postpones to be done later)>

-  ⇤ ← Revision 1 as of 2008-01-11 12:41:43 → 
  Size: 66
  Editor: EldZierau
  Comment:
+   ← Revision 2 as of 2008-01-11 13:00:39 → ⇥
  Size: 2298
  Editor: EldZierau
  Comment:
-Deletions are marked like this.
+Additions are marked like this.
 Line 2:
+= Reviews in iteration XX =
<See [:Code Review Process#CodeReviewOverview:Code Review Overview per Iteration] for description of how to use this template.>
-Line 3:
+Line 5:
+Review of code should happen immediately after coding for a task or bug is done, so as little as possible is based on unreviewed code.
-Line 4:
+Line 7:
-xx
+If the reviewer for some reason cannot be contacted within a reasonable timeframe, another reviewer should be chosen.

We don't register review time as separate from coding time.

For details on how to do a review, see [Code_Review_Process].
||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Class/Page]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Version]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Parts/lines]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Task]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Author(s)]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Reviewer(s)]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Review date]''' ||<bgcolor="#dddddd">'''[:Code Review Process#TableFilledReviewsOverview:Follow-up]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Done]''' ||
|| <Link to code review page for class/JSP-page named with java path name, f.ex. dk.netarkivet.harvestdefinition.JobDAO> || <SVN version of code being reviewed> || <Lines/parts to review> || <Reference to task caused the code changes that are being reviewed as for example a bugs, a feature request or an assignment> || <Initials of author of changes in code> || <Initials of reviewer in code review> ||    <Date that review was held on form YYYY/MM/DD> || <Initials of person to do follow-up on code review> || <Must be either [[BR]] '''''Ok''''' (no further action), [[BR]] '''''Ok w/postponed''''' (no further action within this iteration, but includes postpones to be done later)> ||