= Review (NS-12): Iteration 36 - Java 6 =
|| Author || Søren ||
|| Moderator || Søren ||
|| State || Closed ||
== Objectives ==
{{{
Review of the first java 6 dependent features:
FileUtils.getBytesFree
/trunk/src/dk/netarkivet/common/utils/FileUtils.java, revision 535, line 621-635
Note that these 14 lines replace the functionality of lines 635-839 of the previous revision of this file (r514)
}}}
== Summary ==
{{{
Review is finished; JOLF resulted in a lot of cosmetic defects, most of which did not really belong to this review.
Followup by SVC
}}}
'''General comments''':
|| '''Description''' || '''Classification''' || '''Status''' ||
|| Check that ArgumentNotValid checks all argument in public methods. || Cosmetic || OK ||


=== Comments on file 'trunk/src/dk/netarkivet/common/utils/FileUtils.java', revision 535 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| 80-81 || Need Javadoc. || Cosmetic || OK ||
|| 745 || Add IOFailure to Javadoc. || Cosmetic || OK ||
|| 464-478 || Mention in javadoc that dir is unused in this implementation of accept || Cosmetic || OK ||
|| 716 || Add IOFailure to Javadoc. || Cosmetic || OK ||
|| 1069 || Where is this IOFailure thrown? No where! remove || Cosmetic || OK ||
|| 1003-1004 || Use inDir.getAbsolutePath(), and put into log. || Cosmetic || OK ||
|| 1012-1013 || Use inDir.getAbsolutePath(), and put into log. || Cosmetic || OK ||
|| 905-906 || Use file.getAbsolutePath, and put into log. || Cosmetic || OK ||
|| 951, 954 || Put into log. || Cosmetic || OK ||
|| 1057-1059 || Put into log. || Cosmetic || OK ||
|| 1079-1081 || use file.getAbsolutePath, and put into log. || Cosmetic || OK ||
|| 1029-1030 || Put into log. || Cosmetic || OK ||
|| 1049-1050 || Put into log. || Cosmetic || OK ||
|| 183-184 || No logging, and no Javadoc of IOFailure. || Cosmetic || OK ||
|| 154-155 || Add to Javadoc: throws IOFailure. No logging. || Cosmetic || OK ||
|| 632 || Add logging for this special case || Cosmetic || OK ||
|| 889-890 || Use file.getAbsolutePath, and put into log. || Cosmetic || OK ||
|| 789 || Use f.getAbsolutePath, and also put into log. And add IOFailure to Javadoc. || Cosmetic || OK ||
|| 815 || Use f.getAbsolutePath, and also put into log. And add IOFailure to Javadoc. || Cosmetic || OK ||
|| 672-675 || Replace comments with logging at log.debug. Log that a null is being returned. || Cosmetic || OK ||
|| 761-763 || Put into log. || Cosmetic || OK ||
|| 614 || again, dir => 'dir.getAbsolutePath()' || Cosmetic || OK ||
|| 649-650 || Log that a null is being returned, and remove System.out.... || Cosmetic || OK ||
|| 601 || Use 'dir.getAbsolutePath()' instead of just dir. || Cosmetic || OK ||
|| 607-608 || again, dir => 'dir.getAbsolutePath()' || Cosmetic || OK ||
|| 452 || Tell that a IOFailure can be thrown in the Javadoc. No logging. || Cosmetic || OK ||
|| 567 || No logging. Also use 'file.getAbsolutePath()' instead of just 'file'. || Cosmetic || OK ||
|| 404-406 || No logging, and no Javadoc about IndexOutOfBoundsException. And replace  file with "'" + file.getAbsolutePath() + "'" || Cosmetic || OK ||
|| 426 || No logging. || Cosmetic || OK ||
|| 345-346 || No logging. || Cosmetic || OK ||
|| 366-368, 372, 376, 382 || No logging. || Cosmetic || OK ||