Review (NS-16): Bugfix 1152

Author

Colin

Moderator

Colin

State

Closed

Objectives

Total Time Used (Coding,Documentation,Review): 
Time use (Coding,Documentation,Review)
CSR: 2 MD
SVC: 0.5 MD
General comments: 
  
 Description 

  
 Classification 

  
 Status 






Comments on file 'trunk/src/dk/netarkivet/common/distribute/arcrepository/ARCLookup.java', revision 584


  
 Lines 

  
 Description 

  
 Classification 

  
 Status 




  
 115 

  
 missing spaces between arguments 

  
 Cosmetic 

  
 OK 






Comments on file 'trunk/src/dk/netarkivet/viewerproxy/WebProxy.java', revision 584


  
 Lines 

  
 Description 

  
 Classification 

  
 Status 




  
 289 

  
 Spelling: charcters 

  
 Cosmetic 

  
 OK 




|| 295 || Make consistent or explain why "{" is escaped and not "}"? || Minor || OK || 
  
 288 

  
 You probably meant: java.net.URI(String s) Adapt javadoc to liittle bit more precise 

  
 Cosmetic 

  
 OK 




  
 272 

  
 Improperly named variable: Should be renamed to uriString 

  
 Cosmetic 

  
 OK 




IssuesFoundInReviewNs16  (last edited 2010-08-16 10:25:15 by localhost)