Differences between revisions 3 and 4
⇤ ← Revision 3 as of 2009-03-13 09:16:30 →
Size: 1108
Editor: ColinRosenthal
Comment:
← Revision 4 as of 2010-08-16 10:24:30 → ⇥
Size: 1108
Editor: localhost
Comment: converted to 1.6 markup
No differences found!

Review (NS-22): BugFix 1336

Author

Colin

Moderator

Colin

State

Closed

Objectives



Summary


Reviewed. Cosmetic defects to be fixed by Colin.
Total Time Used (Coding,Documentation,Review): 
Time use (Coding,Documentation,Review)
CSR: 1
SVC:  0.5
General comments: 
  
 Description 

  
 Classification 

  
 Status 






Comments on file 'trunk/src/dk/netarkivet/common/utils/JMXUtils.java', revision 713


  
 Lines 

  
 Description 

  
 Classification 

  
 Status 




  
 125 

  
 Add comment: "Use the default RMI port" (Whatever that is??) 

  
 Cosmetic 

  
 OK 




  
 252-256 

  
 Wrong identation 

  
 Cosmetic 

  
 OK 




  
 247-256 

  
 The exceptions are not logged here; And only the final exception after giving up are included in the IOFailure. Logging must be done at warning level 

  
 NA 

  
NA 




  
 298-307 

  
 The exceptions caught are not logged here, and only the final exception after giving up are included in the IOFailure. Please log at level warning 

  
 Cosmetic 

  
 OK 




IssuesFoundInReviewNs22  (last edited 2010-08-16 10:24:30 by localhost)