NetarchiveSuite|
⇤ ← Revision 1 as of 2009-02-20 12:56:25
Size: 1132
Comment:
|
Size: 1129
Comment:
|
| Deletions are marked like this. | Additions are marked like this. |
| Line 30: | Line 30: |
| || 247-256 || The exceptions are not logged here; And only the final exception after giving up are included in the IOFailure. Logging must be done at warning level || NA || NOTOK || || 298-307 || The exceptions caught are not logged here, and only the final exception after giving up are included in the IOFailure Please log at level warning || Cosmetic || NOTOK || |
|| 247-256 || The exceptions are not logged here; And only the final exception after giving up are included in the IOFailure. Logging must be done at warning level || NA || NOTOK || || 298-307 || The exceptions caught are not logged here, and only the final exception after giving up are included in the IOFailure. Please log at level warning || Cosmetic || NOTOK || |
Review (NS-22): BugFix 1336
Author |
Colin |
Moderator |
Colin |
State |
Closed |
Objectives
Summary
Reviewed. Cosmetic defects to be fixed by Colin.
Total Time Used (Coding,Documentation,Review):
Time use (Coding,Documentation,Review) CSR: 1 SVC: 0.5
General comments:
Description |
Classification |
Status |
Comments on file 'trunk/src/dk/netarkivet/common/utils/JMXUtils.java', revision 713
Lines |
Description |
Classification |
Status |
125 |
Add comment: "Use the default RMI port" (Whatever that is??) |
Cosmetic |
NOTOK |
252-256 |
Wrong identation |
Cosmetic |
NOTOK |
247-256 |
The exceptions are not logged here; And only the final exception after giving up are included in the IOFailure. Logging must be done at warning level |
NA |
NOTOK |
298-307 |
The exceptions caught are not logged here, and only the final exception after giving up are included in the IOFailure. Please log at level warning |
Cosmetic |
NOTOK |