Differences between revisions 2 and 3
Revision 2 as of 2009-02-20 12:56:52
Size: 1129
Comment:
Revision 3 as of 2009-03-13 09:16:30
Size: 1108
Comment:
Deletions are marked like this. Additions are marked like this.
Line 7: Line 7:
Line 10: Line 9:
{{{  {{{
Line 14: Line 13:
{{{ 
{{{
Line 16: Line 16:
Line 18: Line 17:
Line 21: Line 19:
Line 28: Line 25:
|| 125 || Add comment: "Use the default RMI port" (Whatever that is??) || Cosmetic || NOTOK ||
|| 252-256 || Wrong identation || Cosmetic || NOTOK ||
|| 247-256 || The exceptions are not logged here; And only the final exception after giving up are included in the IOFailure. Logging must be done at warning level || NA || NOTOK ||
|| 298-307 || The exceptions caught are not logged here, and only the final exception after giving up are included in the IOFailure. Please log at level warning || Cosmetic || NOTOK ||
|| 125 || Add comment: "Use the default RMI port" (Whatever that is??) || Cosmetic || OK ||
|| 252-256 || Wrong identation || Cosmetic || OK ||
|| 247-256 || The exceptions are not logged here; And only the final exception after giving up are included in the IOFailure. Logging must be done at warning level || NA ||NA ||
|| 298-307 || The exceptions caught are not logged here, and only the final exception after giving up are included in the IOFailure. Please log at level warning || Cosmetic || OK ||

Review (NS-22): BugFix 1336

Author

Colin

Moderator

Colin

State

Closed

Objectives

Summary

Reviewed. Cosmetic defects to be fixed by Colin.

Total Time Used (Coding,Documentation,Review):

Time use (Coding,Documentation,Review)
CSR: 1
SVC:  0.5

General comments:

Description

Classification

Status

Comments on file 'trunk/src/dk/netarkivet/common/utils/JMXUtils.java', revision 713

Lines

Description

Classification

Status

125

Add comment: "Use the default RMI port" (Whatever that is??)

Cosmetic

OK

252-256

Wrong identation

Cosmetic

OK

247-256

The exceptions are not logged here; And only the final exception after giving up are included in the IOFailure. Logging must be done at warning level

NA

NA

298-307

The exceptions caught are not logged here, and only the final exception after giving up are included in the IOFailure. Please log at level warning

Cosmetic

OK

IssuesFoundInReviewNs22 (last edited 2010-08-16 10:24:30 by localhost)