Review (NS-25): Review of method: dk.netarkivet.common.utils.FileUtils.getResourceFileFromClassPath()
Author |
Jonas |
Moderator |
Jonas |
State |
Closed |
Objectives
Review of the method: 'getResourceFileFromClassPath'. Lines: 1219 - 1245.
General comments:
Description |
Classification |
Status |
Comments on file 'trunk/src/dk/netarkivet/common/utils/FileUtils.java', revision 731
Lines |
Description |
Classification |
Status |
1224 |
Mention under which circumstances the method throws an IOException |
Cosmetic |
OK |
1222 |
This is wrong. It is not "The path of the class", but "The path of the file" |
Cosmetic |
OK |
1230 |
Wrong; replace "String default...." with "String filePath" |
Cosmetic |
OK |
1223 |
Wrong @return comment. Mention when the method returns null |
Cosmetic |
OK |
1239-1240 |
Replace System.out.println with logmessage. And replace incorrect message with a correct message. |
Cosmetic |
OK |
1231-1242 |
Catch any IOException, and rethrow as an IOFailure Throw IOFailure if unable to read the stream corresponding to the wanted resource |
Cosmetic |
OK |