Differences between revisions 2 and 3
⇤ ← Revision 2 as of 2009-03-20 13:37:12 →
Size: 4821
Editor: SoerenCarlsen
Comment:
← Revision 3 as of 2009-03-24 14:14:16 → ⇥
Size: 4792
Editor: SoerenCarlsen
Comment:
Deletions are marked like this. Additions are marked like this.
Line 8: Line 8:
Line 11: Line 10:
Job r. 671, lines 138-193, 148-152, 664-669, 1271-1294 
JobDBDAO, r671, lines 64-68, 76-83, 119-155, 276-286, 320-324, 362-370, 392-394, 435-437, 427-429, 581-586, 603-612, 692-697, 727-737, 910-912 (needs to be updated), 938-943, 		 Job r. 671, lines 138-193, 148-152, 664-669, 1271-1294
JobDBDAO, r671, lines 64-68, 76-83, 119-155, 276-286, 320-324, 362-370, 392-394, 435-437, 427-429, 581-586, 603-612, 692-697, 727-737, 910-912 (needs to be updated), 938-943,
Line 21: Line 20:
Line 25: Line 23:
{{{  {{{
Line 29: Line 27:
{{{ 
{{{
Line 34: Line 33:
Line 37: Line 35:
|| Add the database changes to the sql create scripts in trunk/sql/scripts/sql || Minor || NOTOK ||
|| Upload the scripts needed by netarkivet PROD system to by pass the migration of tables fullharvests (from version 2 to 3), and configurations (from version 3 to 4) || Cosmetic || NOTOK ||		 || Add the database changes to the sql create scripts in trunk/sql/scripts/sql || Minor || OK ||
|| Upload the scripts needed by netarkivet PROD system to by pass the migration of tables fullharvests (from version 2 to 3), and configurations (from version 3 to 4) || Cosmetic || OK ||
Line 47: Line 45:
|| 673 || Get a list of which settings.xml files? heritrix settings files, not netarkivet || Cosmetic || NOTOK || || 673 || Get a list of which settings.xml files? heritrix settings files, not netarkivet || Cosmetic || OK ||
Line 50: Line 48:
|| 410 || Unnecessary whitespace || Cosmetic || NOTOK || || 410 || Unnecessary whitespace || Cosmetic ||REJECTED ||
Line 63: Line 61:
|| 70 || Document side-effect (updating of table version). document postcondition that version is the required version. || Cosmetic || NOTOK ||
|| 469 || Shouldn't this be rethrown as a netarkivet exception? investigate where the documentexception is caught and consider whether to catch and rethrow as netarkivetexception. || Cosmetic || NOTOK ||		 || 70 || Document side-effect (updating of table version). document postcondition that version is the required version. || Cosmetic || OK ||
|| 469 || Shouldn't this be rethrown as a netarkivet exception? investigate where the documentexception is caught and consider whether to catch and rethrow as netarkivetexception. || Cosmetic ||OK ||
Line 71: Line 69:
|| 30 || "response" spelling || Cosmetic || NOTOK ||
|| 48 || long line || Cosmetic || NOTOK ||
|| 90 || Document what this catch block is doing || Cosmetic || NOTOK ||
|| 102 || This is the link from the original job to the resubmitted job. Some javadoc needed. || Cosmetic || NOTOK ||		 || 30 || "response" spelling || Cosmetic || OK ||
|| 48 || long line || Cosmetic ||REJECTED ||
|| 90 || Document what this catch block is doing || Cosmetic || OK ||
|| 102 || This is the link from the original job to the resubmitted job. Some javadoc needed. || Cosmetic || OK ||

Review (NS-28): Review for Bug 1226, and Feature requests 770 and 1146

Author

Søren

Moderator

Søren

State

Closed

Objectives

Review of the code fixing bug 1226, and features 770 and 1146:
Changes to add information of the new resubmitted Job Id, when a Job is resubmitted
JobStatusInfo, r 673, lines 51-53, 57-102, 167-172, 189-195
Job r. 671, lines 138-193, 148-152, 664-669, 1271-1294
JobDBDAO, r671, lines 64-68, 76-83, 119-155, 276-286, 320-324, 362-370, 392-394, 435-437, 427-429, 581-586, 603-612, 692-697, 727-737, 910-912 (needs to be updated), 938-943,
998-1009, 1015-1025
MySQLSpecifics, r671, lines 153-188
DBSpecifics. r671, lines 128-239, 249-264
DomainDBDAO, r671, lines 66,77-85, 88
DerbySpecifics, r671, lines 44, 257-291
HarvestDefinitionDAO, r671, lines 61,66-74, 77
HarvestScheduler, r672, line 296
 /trunk/webpages/History/Harveststatus-jobdetails.jsp, r. 674, lines 70, 94-105, 117, 130-138
Translation-files: Added key table.job.submittedtime

Summary

Follow up from the review will be done by SVC

Total Time Used (Coding,Documentation,Review): 

Time use (Coding,Documentation,Review)
svc: 2md
csr: 0.5md

General comments:

Description

Classification

Status

Add the database changes to the sql create scripts in trunk/sql/scripts/sql

Minor

OK

Upload the scripts needed by netarkivet PROD system to by pass the migration of tables fullharvests (from version 2 to 3), and configurations (from version 3 to 4)

Cosmetic

OK

Comments on file 'trunk/src/dk/netarkivet/harvester/Translations.properties', revision 674

Lines

Description

Classification

Status

Comments on file 'trunk/src/dk/netarkivet/harvester/Translations_da.properties', revision 674

Lines

Description

Classification

Status

Comments on file 'trunk/src/dk/netarkivet/harvester/datamodel/Job.java', revision 671

Lines

Description

Classification

Status

673

Get a list of which settings.xml files? heritrix settings files, not netarkivet

Cosmetic

OK

Comments on file 'trunk/src/dk/netarkivet/harvester/Translations_de.properties', revision 674

Lines

Description

Classification

Status

410

Unnecessary whitespace

Cosmetic

REJECTED

Comments on file 'trunk/src/dk/netarkivet/harvester/datamodel/DomainDBDAO.java', revision 671

Lines

Description

Classification

Status

Comments on file 'trunk/src/dk/netarkivet/harvester/datamodel/DBSpecifics.java', revision 671

Lines

Description

Classification

Status

Comments on file 'trunk/src/dk/netarkivet/harvester/datamodel/JobStatusInfo.java', revision 673

Lines

Description

Classification

Status

Comments on file 'trunk/src/dk/netarkivet/harvester/datamodel/HarvestDefinitionDBDAO.java', revision 671

Lines

Description

Classification

Status

Comments on file 'trunk/src/dk/netarkivet/harvester/datamodel/MySQLSpecifics.java', revision 671

Lines

Description

Classification

Status

Comments on file 'trunk/src/dk/netarkivet/harvester/datamodel/JobDBDAO.java', revision 671

Lines

Description

Classification

Status

70

Document side-effect (updating of table version). document postcondition that version is the required version.

Cosmetic

OK

469

Shouldn't this be rethrown as a netarkivet exception? investigate where the documentexception is caught and consider whether to catch and rethrow as netarkivetexception.

Cosmetic

OK

Comments on file 'trunk/src/dk/netarkivet/harvester/datamodel/DerbySpecifics.java', revision 671

Lines

Description

Classification

Status

Comments on file 'trunk/src/dk/netarkivet/harvester/scheduler/HarvestScheduler.java', revision 672

Lines

Description

Classification

Status

Comments on file 'trunk/webpages/History/Harveststatus-jobdetails.jsp', revision 674

Lines

Description

Classification

Status

30

"response" spelling

Cosmetic

OK

48

long line

Cosmetic

REJECTED

90

Document what this catch block is doing

Cosmetic

OK

102

This is the link from the original job to the resubmitted job. Some javadoc needed.

Cosmetic

OK

IssuesFoundInReviewNs28 (last edited 2010-08-16 10:24:30 by localhost)