Differences between revisions 1 and 5 (spanning 4 versions)

Review (NS-30): System state

Author	Jonas
Moderator	Jonas
State	Closed

Objectives

trunk/src/dk/netarkivet/common/management/Constants.java -> All lines.
trunk/src/dk/netarkivet/common/management/SingleMBeanObject.java -> Lines 116 - 140.
trunk/src/dk/netarkivet/monitor/Translations_de.properties -> Lines 52-53.
trunk/src/dk/netarkivet/monitor/webinterface/JMXSummaryUtils.java -> Lines: 41-78, 110-145, 171-213, 312-313, and 394-424.
trunk/webpages/Status/Monitor-JMXsummary.jsp -> Lines 76 - 254.
trunk/src/dk/netarkivet/monitor/Translations.properties -> Lines: 34-35
trunk/src/dk/netarkivet/monitor/Translations_da.properties -> Lines: 34-35

Summary

Time use (Coding,Documentation,Review)
SVC:  0.5
JOLF: 3

General comments:

Description

Classification

Status

Comments on file 'trunk/src/dk/netarkivet/common/management/SingleMBeanObject.java', revision 699

Lines	Description	Classification	Status
84	getLog(..) should be getLog(SingleMbeanObject.class.getName())	Cosmetic	OK
68	rename as exposedObject	Cosmetic	OK
131, 138	Should we not catch UnknownID in both places? Yes	Cosmetic	OK
100	o => exposedObject	Cosmetic	OK
132-133, 139-140	Should we log here; Beware, that logentries may flood the logs. If logging is chosen, then at lowest level (trace), so it is by default disabled	Cosmetic	OK

Comments on file 'trunk/src/dk/netarkivet/monitor/Translations_de.properties', revision 725

Lines	Description	Classification	Status
52	Hide is "verstecken" or "verbergen" in German	Cosmetic	OK

Comments on file 'trunk/src/dk/netarkivet/monitor/webinterface/JMXSummaryUtils.java', revision 725

Lines	Description	Classification	Status
312-313	replace "*", "-" with constants	Cosmetic	OK
237	Consider adding a constant for the string "Status/Monitor-JMXSummary.jsp"	Cosmetic	OK
410-418	replace return strings with constants	Cosmetic	OK
128	Make "-" a local constant	Cosmetic	OK
207-208	Missing argument validation	Cosmetic	OK
131	Make "*" constant	Cosmetic	OK

Comments on file 'trunk/src/dk/netarkivet/common/management/Constants.java', revision 696

Lines	Description	Classification	Status
54	Should be named PRIORITY_KEY_REPLICANAME	Cosmetic	OK

-  ⇤ ← Revision 1 as of 2009-03-19 18:11:27 → 
  Size: 2616
  Editor: SoerenCarlsen
  Comment:
+   ← Revision 5 as of 2010-08-16 10:24:42 → ⇥
  Size: 2671
  Editor: localhost
  Comment: converted to 1.6 markup
-Deletions are marked like this.
+Additions are marked like this.
 Line 15:
+== Summary ==
{{{
Time use (Coding,Documentation,Review)
SVC:  0.5
JOLF: 3 
}}}
-Line 17:
+Line 25:
-Line 19:
+Line 29:
-|| 84 || getLog(..) should be getLog(SingleMbeanObject.class.getName()) || Cosmetic || NOTOK ||
|| 68 || rename as exposedObject || Cosmetic || NOTOK ||
|| 131, 138 || Should we not catch UnknownID in both places? Yes || Cosmetic || NOTOK ||
|| 100 || o => exposedObject || Cosmetic || NOTOK ||
|| 132-133, 139-140 || Should we log here; Beware, that logentries may flood the logs. If logging is chosen, then at lowest level (trace), so it is by default disabled || Cosmetic || NOTOK ||
+|| 84 || getLog(..) should be getLog(SingleMbeanObject.class.getName()) || Cosmetic || OK ||
|| 68 || rename as exposedObject || Cosmetic || OK ||
|| 131, 138 || Should we not catch UnknownID in both places? Yes || Cosmetic || OK ||
|| 100 || o => exposedObject || Cosmetic || OK ||
|| 132-133, 139-140 || Should we log here; Beware, that logentries may flood the logs. If logging is chosen, then at lowest level (trace), so it is by default disabled || Cosmetic || OK ||
-Line 26:
+Line 36:
-|| 52 || Hide is "verstecken" or "verbergen" in German || Cosmetic || NOTOK ||
+|| 52 || Hide is "verstecken" or "verbergen" in German || Cosmetic || OK ||
-Line 29:
+Line 39:
-|| 312-313 || replace "*", "-" with constants || Cosmetic || NOTOK ||
|| 237 || Consider adding a constant for the string "Status/Monitor-JMXSummary.jsp" || Cosmetic || NOTOK ||
|| 410-418 || replace return strings with constants || Cosmetic || NOTOK ||
|| 128 || Make "-" a local constant || Cosmetic || NOTOK ||
|| 207-208 || Missing argument validation || Cosmetic || NOTOK ||
|| 131 || Make "*" constant || Cosmetic || NOTOK ||
+|| 312-313 || replace "*", "-" with constants || Cosmetic || OK ||
|| 237 || Consider adding a constant for the string "Status/Monitor-JMXSummary.jsp" || Cosmetic || OK ||
|| 410-418 || replace return strings with constants || Cosmetic || OK ||
|| 128 || Make "-" a local constant || Cosmetic || OK ||
|| 207-208 || Missing argument validation || Cosmetic || OK ||
|| 131 || Make "*" constant || Cosmetic || OK ||
-Line 37:
+Line 47:
-|| 54 || Should be named PRIORITY_KEY_REPLICANAME || Cosmetic || NOTOK ||
+|| 54 || Should be named PRIORITY_KEY_REPLICANAME || Cosmetic || OK ||