Review (NS-30): System state
Author |
Jonas |
Moderator |
Jonas |
State |
Closed |
Objectives
trunk/src/dk/netarkivet/common/management/Constants.java -> All lines. trunk/src/dk/netarkivet/common/management/SingleMBeanObject.java -> Lines 116 - 140. trunk/src/dk/netarkivet/monitor/Translations_de.properties -> Lines 52-53. trunk/src/dk/netarkivet/monitor/webinterface/JMXSummaryUtils.java -> Lines: 41-78, 110-145, 171-213, 312-313, and 394-424. trunk/webpages/Status/Monitor-JMXsummary.jsp -> Lines 76 - 254. trunk/src/dk/netarkivet/monitor/Translations.properties -> Lines: 34-35 trunk/src/dk/netarkivet/monitor/Translations_da.properties -> Lines: 34-35
General comments:
Description |
Classification |
Status |
Comments on file 'trunk/src/dk/netarkivet/common/management/SingleMBeanObject.java', revision 699
Lines |
Description |
Classification |
Status |
84 |
getLog(..) should be getLog(SingleMbeanObject.class.getName()) |
Cosmetic |
OK |
68 |
rename as exposedObject |
Cosmetic |
OK |
131, 138 |
Should we not catch UnknownID in both places? Yes |
Cosmetic |
OK |
100 |
o => exposedObject |
Cosmetic |
OK |
132-133, 139-140 |
Should we log here; Beware, that logentries may flood the logs. If logging is chosen, then at lowest level (trace), so it is by default disabled |
Cosmetic |
OK |
Comments on file 'trunk/src/dk/netarkivet/monitor/Translations_de.properties', revision 725
Lines |
Description |
Classification |
Status |
52 |
Hide is "verstecken" or "verbergen" in German |
Cosmetic |
NOTOK |
Comments on file 'trunk/src/dk/netarkivet/monitor/webinterface/JMXSummaryUtils.java', revision 725
Lines |
Description |
Classification |
Status |
312-313 |
replace "*", "-" with constants |
Cosmetic |
NOTOK |
237 |
Consider adding a constant for the string "Status/Monitor-JMXSummary.jsp" |
Cosmetic |
NOTOK |
410-418 |
replace return strings with constants |
Cosmetic |
NOTOK |
128 |
Make "-" a local constant |
Cosmetic |
NOTOK |
207-208 |
Missing argument validation |
Cosmetic |
NOTOK |
131 |
Make "*" constant |
Cosmetic |
NOTOK |
Comments on file 'trunk/src/dk/netarkivet/common/management/Constants.java', revision 696
Lines |
Description |
Classification |
Status |
54 |
Should be named PRIORITY_KEY_REPLICANAME |
Cosmetic |
NOTOK |