= Review (NS-33): Settings and channel changes =
|| Author || Eld Zierau ||
|| Moderator || Eld Zierau ||
|| State || Closed ||
== Objectives ==
{{{
This review also includes NS-36 and NS-37. The split was necessary in order to increase reaction time of the current Crucible installation.

This review mainly concerns changes and clean up of setting, and implementing: Assignment B.2.2a0 - Separate the meaning of replica and physical location. All files not mentioned in the below lists only concerns:
- Move of comments from settings into javadoc
- Refactoring (replica instead of location, Id instead of name)

Especially concerned with conversion of replica names (for interfaces) to is ids (for channels and internal use):
/trunk/src/dk/netarkivet/archive/webinterface/BitpreserveFileState.java All -  replica names from interface (to id)
/trunk/src/dk/netarkivet/archive/tools/RunBatch.java
/trunk/src/dk/netarkivet/archive/bitarchive/distribute/BatchMessage.java  

New use of http, replica, applid (System state)
/trunk/src/dk/netarkivet/common/management/SingleMBeanObject.java (also new harvester priority)
/trunk/src/dk/netarkivet/monitor/Translations.properties
/trunk/src/dk/netarkivet/monitor/Translations_da.properties

THIS HACO bug 291, 1308 
/trunk/src/dk/netarkivet/common/distribute/ChannelID.java 
/trunk/src/dk/netarkivet/archive/arcrepository/bitpreservation/AdminDataMessage.java
/trunk/src/dk/netarkivet/archive/arcrepository/distribute/ArcRepositoryServer.java  line 66 HACO - (channel name)
/trunk/src/dk/netarkivet/archive/arcrepository/distribute/StoreMessage.java  line 53 HACO - (channel name)
/trunk/src/dk/netarkivet/archive/bitarchive/distribute/BitarchiveClient.java HACO line 54 - (channel name)
/trunk/src/dk/netarkivet/archive/arcrepository/distribute/JMSArcRepositoryClient.java  line 143, 193     
/trunk/src/dk/netarkivet/harvester/harvesting/distribute/HarvestControllerServer.java line 189, 400
/trunk/src/dk/netarkivet/common/distribute/Channels.java 

JMX - clean-up in users and passwords
/trunk/src/dk/netarkivet/monitor/settings.xml
/trunk/src/dk/netarkivet/monitor/webinterface/JMXStatusEntry.java
/trunk/scripts/simple_harvest/quickstart.jmxremote.password                 (MISSING)
/trunk/scripts/simple_harvest/settings.xml
/trunk/conf/jmxremote_template.password
}}}
'''Total Time Used (Coding,Documentation,Review)''':
{{{ 
time is registered under review NS-37 and
Time use (Coding,Documentation,Review)
JOLF: 0,2
}}}

=== Comments on file 'trunk/src/dk/netarkivet/viewerproxy/GetDataResolver.java', revision 626 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/archive/arcrepository/distribute/JMSArcRepositoryClient.java', revision 727 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/viewerproxy/LocalCDXCache.java', revision 626 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/archive/arcrepository/distribute/StoreMessage.java', revision 675 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/common/distribute/arcrepository/ArcRepositoryClient.java', revision 591 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/archive/arcrepositoryadmin/ArcRepositoryEntry.java', revision 591 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/common/distribute/arcrepository/PreservationArcRepositoryClient.java', revision 591 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/archive/bitarchive/distribute/BitarchiveClient.java', revision 675 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/common/utils/ApplicationUtils.java', revision 591 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/common/management/SingleMBeanObject.java', revision 626 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/archive/arcrepository/bitpreservation/ActiveBitPreservation.java', revision 591 ===
None
=== Comments on file 'trunk/scripts/simple_harvest/settings.xml', revision 591 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/common/distribute/arcrepository/TrivialArcRepositoryClient.java', revision 591 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| 186 || bitarchiveId (uppercase 'i') || Cosmetic || OK ||
=== Comments on file 'trunk/src/dk/netarkivet/monitor/Translations.properties', revision 626 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/harvester/harvesting/distribute/HarvestControllerServer.java', revision 675 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/common/distribute/arcrepository/LocalArcRepositoryClient.java', revision 591 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/archive/arcrepositoryadmin/AdminData.java', revision 591 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/monitor/Translations_de.properties', revision 626 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/archive/bitarchive/distribute/RemoveAndGetFileMessage.java', revision 675 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/monitor/webinterface/JMXStatusEntry.java', revision 727 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/archive/arcrepository/bitpreservation/WorkFiles.java', revision 591 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/archive/tools/GetFile.java', revision 626 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/archive/Translations.properties', revision 647 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| 61-62, 64, 66-67 || physicalLocation or replica? || Cosmetic || OK ||
=== Comments on file 'trunk/src/dk/netarkivet/archive/tools/RunBatch.java', revision 647 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/archive/arcrepository/bitpreservation/FilePreservationState.java', revision 591 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/archive/Translations_da.properties', revision 647 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/viewerproxy/webinterface/Reporting.java', revision 626 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/archive/bitarchive/distribute/GetFileMessage.java', revision 591 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/monitor/webinterface/StatusEntry.java', revision 727 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/archive/webinterface/BitpreserveFileState.java', revision 616 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/archive/Translations_de.properties', revision 778 ===
None
=== Comments on file 'trunk/conf/jmxremote_template.password', revision 718 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/harvester/tools/CreateCDXMetadataFile.java', revision 626 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/archive/bitarchive/distribute/BitarchiveMonitorServer.java', revision 626 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/archive/arcrepository/bitpreservation/FileBasedActiveBitPreservation.java', revision 591 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/archive/arcrepository/distribute/ArcRepositoryServer.java', revision 675 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/archive/indexserver/RawMetadataCache.java', revision 626 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/common/settings.xml', revision 717 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/common/distribute/arcrepository/ViewerArcRepositoryClient.java', revision 591 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/monitor/Translations_da.properties', revision 626 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/archive/arcrepository/ArcRepository.java', revision 602 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/archive/arcrepository/bitpreservation/AdminDataMessage.java', revision 675 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/archive/bitarchive/distribute/BitarchiveServer.java', revision 616 ===
None
=== Comments on file 'trunk/src/dk/netarkivet/archive/bitarchive/distribute/BatchMessage.java', revision 591 ===
None