Review (NS-35): Review of fix for bug 1519: Harvesting with no domains gives runs without history
Author |
Søren |
Moderator |
Søren |
State |
Review |
Objectives
Review the following lines /trunk/src/dk/netarkivet/harvester/Translations.properties, r561, line 118 /trunk/src/dk/netarkivet/harvester/Translations_da.properties, r561, line 115 /trunk/src/dk/netarkivet/harvester/Translations_de.properties, r561, line 91 /trunk/webpages/HarvestDefinition/Definitions-selective-harvests.jsp, r561, lines 50-74
Total Time Used (Coding,Documentation,Review):
Time use (Coding,Documentation,Review) SVC: 0.25 JOLF: 0.1
General comments:
Description |
Classification |
Status |
Change key-words to constants. |
Cosmetic |
POSTPONED |
Comments on file 'trunk/src/dk/netarkivet/harvester/Translations.properties', revision 561
Lines |
Description |
Classification |
Status |
Comments on file 'trunk/src/dk/netarkivet/harvester/Translations_da.properties', revision 561
Lines |
Description |
Classification |
Status |
Comments on file 'trunk/src/dk/netarkivet/harvester/Translations_de.properties', revision 561
Lines |
Description |
Classification |
Status |
Comments on file 'trunk/webpages/HarvestDefinition/Definitions-selective-harvests.jsp', revision 561
Lines |
Description |
Classification |
Status |
44 |
Add "History" to harvester.webinterface.Constants |
Cosmetic |
OK |
48 |
Replace flipactive with constant harvester.webinterface.Constants.FLIPACTIVE_PARAM |
Cosmetic |
OK |
62 |
Wrong indentation |
Cosmetic |
OK |
71 |
Make constant. |
Cosmetic |
REJECTED |
134 |
"-" should be a constant. Constant for 'No next date' |
Cosmetic |
OK |