= Review (NS-38): Review of bug 1566 =
|| Author || Søren ||
|| Moderator || Søren ||
|| State || Closed ||
== Objectives ==
{{{
This tries to fix the problem with deduplication (1566).
CrawlLogIndexCache, r786, lines 84-85, 94, 101-114
CombiningMultiFileBasedCache, r786, lines 75, 102-109
CDXIndexCache.java, r786, lines 34, 65-70
}}}
== Summary ==
{{{
Followup by SVC
}}}
'''Total Time Used (Coding,Documentation,Review)''':

{{{
Time use (Coding,Documentation,Review)
SVC: 1.5 MD
JOLF:0.5 MD
}}}
'''General comments''':
|| '''Description''' || '''Classification''' || '''Status''' ||


=== Comments on file 'trunk/src/dk/netarkivet/archive/indexserver/CrawlLogIndexCache.java', revision 786 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| 94 || Should this be written, when no IDs are missing? Perhaps check whether missing.isEmpty(); || Cosmetic || OK ||
|| 144 || change 'resultFile' to 'resultFile.getAbsolutePath()' || Cosmetic || OK ||
=== Comments on file 'trunk/src/dk/netarkivet/archive/indexserver/CombiningMultiFileBasedCache.java', revision 786 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| 66 || Javadoc || Cosmetic || OK ||
=== Comments on file 'trunk/src/dk/netarkivet/archive/indexserver/CDXIndexCache.java', revision 786 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| 70 || Javadoc for argument filesRequired || Cosmetic || OK ||