NetarchiveSuite
Review (NS-41): Bug 1613: Only monitorRole and controlRole works as JMX usernames
Author |
Søren |
Moderator |
Søren |
State |
Closed |
Objectives
Verify the fix for bug 1613. Includes changes to deploy, and changes to JMXHeritrixController
Summary
Follow up by JOLF
Total Time Used (Coding,Documentation,Review):
Time use (Coding,Documentation,Review) SVC: 0.5 JOLF: 1.0
General comments:
Description |
Classification |
Status |
Comments on file 'trunk/src/dk/netarkivet/deploy/Machine.java', revision 803
Lines |
Description |
Classification |
Status |
General |
All methods starting with "abstract protected" need to start with "protected abstract" instead. See http://checkstyle.sourceforge.net/config_modifier.html |
Cosmetic |
OK |
411, 415 |
Cut and paste error. Should write: Problems creating " + Constants.JMX_FILE_NAME + ": " + e |
Cosmetic |
OK |
525 |
"under monitor" => for the monitor |
Cosmetic |
OK |
616 |
"hetrix" => Heritrix |
Cosmetic |
OK |
617 |
The Heritrix role is 'readwrite', not readonly. |
Cosmetic |
OK |
630, 643-644 |
Refer to heritrix role, not monitor.jmxUsername |
Cosmetic |
OK |
Comments on file 'trunk/src/dk/netarkivet/deploy/ScriptConstants.java', revision 803
Lines |
Description |
Classification |
Status |
201, 203 |
rename as JMXREMOTE*_PRIVILEGES |
Cosmetic |
OK |