Review (NS-42): Review of bug 1564 (again) and 1629

Author	Søren
Moderator	Søren
State	Closed

Objectives

Review of code changes necessary to fix bug 1564 and 1629:
Comprises changes to
1)  /trunk/src/dk/netarkivet/archive/ArchiveSettings.java (revision 812):
2)  /trunk/src/dk/netarkivet/archive/bitarchive/BitarchiveAdmin.java (revision 812)
3)  /trunk/src/dk/netarkivet/archive/settings.xml (revision 812)

Summary

kfc to followup

General comments:

Description

Classification

Status

Comments on file 'trunk/src/dk/netarkivet/archive/bitarchive/BitarchiveAdmin.java', revision 812

Lines	Description	Classification	Status
197	change to log.warn	Cosmetic	OK

Comments on file 'trunk/src/dk/netarkivet/archive/ArchiveSettings.java', revision 812

Lines	Description	Classification	Status
85	Is it ok with final as modifier here; The other settings does not have this modifier This is wrong; the final must be removed	Minor	OK