Review (MG-8): Updated sBARC2WARC converter, with code style errors and a...

Objectives

MAIN:hbk:20091209093452: Updated sBARC2WARC converter, with code style errors and a small update of code.

Time Use:
SVC: 0.25
HBK: 8.0

General comments:

Description

Classification

Status

Lines	Description	Classification	Status
General	Log the incident instead of printing out the stackstrace	Cosmetic	OK
329	Typo: 'Retrurn' => 'Return'	Cosmetic	OK
345-348	Add that: A dummy harvester hostname is always returned if the file exists; otherwise null is returned	Cosmetic	OK
368-369	Add: A dummy server IP (Constants.ZEROZEROZEROZERO) is always returned if the file exists; otherwise null is returned	Cosmetic	OK
380	Write that Constant.RESPONSE is always returned if the file exists; otherwise null is returned	Cosmetic	OK

Lines	Description	Classification	Status
75-78	Why do you replace the inputDir with the input argument only if the current working directory is a directory? Please correct or add comment.	Cosmetic	OK
79-81	Why do you replace the outputDir with the output argument only if the /tmp/ directory is a (existing) directory? Please correct or add comment.	Cosmetic	OK
149-150	Please add comment here. And why will fileSplit never be null?	Cosmetic	OK