Differences between revisions 2 and 3

Review (NS-102): FR 1751: Create restart script for windows services

Objectives

Total Time Used (Coding,Documentation,Review):

Time use (Coding,Documentation,Review)
JOLF: 0.7
HBK: 0.1

General comments:

Description

Classification

Status

Lines	Description	Classification	Status
827	The Directory where there files will be placed. -- like above	Cosmetic	OK

Lines	Description	Classification	Status
1068, 1104-1107	Same as in WindowsMachine. Bad handling of the error message, and undocumented exception thrown.	Cosmetic	OK

Lines	Description	Classification	Status
1269, 1313	It does not say anywhere, that it might throw an IOFailure.	Cosmetic	OK
1310-1313	Bad message handling. The message it self should be a constant (in Contants like the others), and the error should not be part of the message string, it should be put along the message, e.g. log.trace(msg, e); throw new IOFailure(msg, e); If the error is appended to the message string, it is the same as e.toString(), which only returns the name of the exception, not the cause or stacktrace. Why log.trace? This is ignored. Use log.warn or log.error instead.	Cosmetic	OK
1318-1319	I'll guess you mean 'Creates'	Cosmetic	OK
1322, 1345	It is also here not documented that it might throw an IOFailure. Remenber java-doc	Cosmetic	OK
1342-1345	Same as above.	Cosmetic	OK

⇤ ← Revision 2 as of 2009-10-21 11:37:51 → Size: 2322 Editor: JonasFrellesen Comment:	← Revision 3 as of 2010-08-16 10:24:49 → ⇥ Size: 2322 Editor: localhost Comment: converted to 1.6 markup
No differences found!