Review (NS-110): Refix of bug 1712
Author |
Kåre |
Moderator |
Kåre |
State |
Closed |
Objectives
Reopened and refixed, due to a field being initialised in two different places, and only as a synchronized list in one of them. Made the fields final, to ensure it not happening again. Synchronization on final static fields is really non-unittestable, and non-releasetestable, so we need to make sure this is reviewed properly :-) Sorry about the fairly large changes, only very minor stuff has happened, the rest is automatic reformatting of code in the file. The only relevant lines are: 65-66, 72-73, 385, and removed old lines 402-406
Summary
No comments
Total Time Used (Coding,Documentation,Review):
Time Used: KFC: 0.1 md SVC: 0.1 md
General comments:
Description |
Classification |
Status |