= Review (NS-116): Followup to NS-109. =
|| Author || Henrik Kirk ||
|| Moderator || Henrik Kirk ||
|| State || Closed ||
== Objectives ==
{{{
1098:
Wayback specific files.
}}}
'''Total Time Used (Coding,Documentation,Review)''':
{{{ 
Time use (Coding,Documentation,Review)
HBK: 0.5
CSR: 0.2
}}}

'''General comments''':
|| '''Description''' || '''Classification''' || '''Status''' ||
|| Are these files sanity tested. Ie can you run the wayback ant tasks and get a repackaged (but non-functional) warfile? || Cosmetic || OK ||


=== Comments on file 'trunk/conf/wayback/wayback.xml', revision 1098 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| General || I suggest we remove all the commented out xml so that the configuration is easier to understand. || Cosmetic || OK ||
|| 22 || Document this line. || Cosmetic || OK ||
|| 70, 74 || This documentation doesn't really describe our deployment as we use a CDX collection. Also there is a proxy access point defined so this is not the only access point. || Cosmetic || OK ||
=== Comments on file 'trunk/conf/wayback/settings.xml', revision 1098 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| 39, 46, 48 || It would be good pedagogy to add the one wayback setting here: <wayback>          <urlcanonicalizer>              <classname>                  org.archive.wayback.util.url.AggressiveUrlCanonicalizer              </classname>          </urlcanonicalizer>     </wayback> || Minor || OK ||
=== Comments on file 'trunk/conf/wayback/CDXCollection.xml', revision 1098 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| 11 || Remove the "FlatFile" stuff. || Cosmetic || OK ||
=== Comments on file 'trunk/wayback.build.xml', revision 1100 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| 18 || It would be good to add a check for the existence of this file and an informative warning if it is not found. "Wayback is not currently included with Netarchivesuite. Download it from ... and modify the build file to point to wayback's download directory." || Cosmetic || OK ||
|| 31 || This is actually wrong. Only settings for common and wayback modules are needed. || Cosmetic || OK ||
|| 42 || Spelling error "waybacm" || Cosmetic || OK ||