Differences between revisions 2 and 3

Review (NS-117): Changes in relation to bug 1786

Author	Søren
Moderator	Søren
State	Closed

Objectives

- Verify the changes to Definitions-upload-harvest-template.jsp
- Verify that all language properties files have now the following new keys:
     errormsg;template.upload.failed.with.exception.0
     errormsg;uploading.file.0.failed.it.does.not.exist

Summary

Follow up by SVC

Total Time Used (Coding,Documentation,Review):

Time use (Coding,Documentation,Review)
JOLF: 0.1
SVC: 0.5

General comments:

Description

Classification

Status

Comments on file 'trunk/src/dk/netarkivet/harvester/Translations_it.properties', revision 1103

Lines	Description	Classification	Status
114	Delete this line	Cosmetic	OK
115	Missing space between 'fallito.' and 'Questo'	Cosmetic	OK

Comments on file 'trunk/src/dk/netarkivet/harvester/Translations.properties', revision 1103

Lines	Description	Classification	Status
232-233	Why has this been moved? Shouldn't these be amongst the other error-messages for the harvester.	Cosmetic	REJECTED

Comments on file 'trunk/src/dk/netarkivet/harvester/Translations_de.properties', revision 1103

Lines	Description	Classification	Status
118	A space is missing. between 'fehlgeschlagen.' and 'Es'	Cosmetic	OK

-  ⇤ ← Revision 2 as of 2009-10-29 16:09:32 → 
  Size: 1582
  Editor: SoerenCarlsen
  Comment:
+   ← Revision 3 as of 2009-10-29 16:16:11 → ⇥
  Size: 1574
  Editor: SoerenCarlsen
  Comment:
-Deletions are marked like this.
+Additions are marked like this.
 Line 29:
-|| 114 || Delete this line || Cosmetic || NOTOK ||
|| 115 || Missing space between 'fallito.' and 'Questo' || Cosmetic || NOTOK ||
+|| 114 || Delete this line || Cosmetic || OK ||
|| 115 || Missing space between 'fallito.' and 'Questo' || Cosmetic ||OK ||
 Line 33:
-|| 232-233 || Why has this been moved? Shouldn't these be amongst the other error-messages for the harvester. || Cosmetic || NOTOK ||
+|| 232-233 || Why has this been moved? Shouldn't these be amongst the other error-messages for the harvester. || Cosmetic ||REJECTED ||
 Line 36:
-|| 118 || A space is missing. between 'fehlgeschlagen.' and 'Es' || Cosmetic || NOTOK ||
+|| 118 || A space is missing. between 'fehlgeschlagen.' and 'Es' || Cosmetic || OK ||