Review (NS-126): FR 1757 - this solution removes an application from the Monitor...

Author

Henrik Kirk

Moderator

Henrik Kirk

State

Closed

Objectives

1165: FR 1757 - this solution removes an application from the Monitor page, but if this applications isn't dead, it will not register it self automaticly.

Total Time Used (Coding,Documentation,Review):

Time use (Coding,Documentation,Review) 
HBK: 3.5 md 
SVC: 0.25 md

General comments:

Description

Classification

Status

Add Danish translation in the Danish translation properties for the monitor module

Cosmetic

OK

|| Add entries in the French, German, and Italian translation property files for the monitor module. Make it a copy of the English entry. || Cosmetic || OK ||

Shouldn't it be possible to hide the "remove application" column?

Cosmetic

OK

Comments on file 'trunk/webpages/Status/Monitor-JMXsummary.jsp', revision 1165

Lines

Description

Classification

Status

59

Finish sentence

Cosmetic

OK

97

Why not let field show a button instead of the machine name?

Cosmetic

OK

Comments on file 'trunk/src/dk/netarkivet/monitor/webinterface/JMXSummaryUtils.java', revision 1165

Lines

Description

Classification

Status

334

Validate arguments 'parameters', 'request', and 'context'.

Cosmetic

OK

374

Add ArgumentNotValid.checkNotNull() for argument "parameters"

Cosmetic

OK

Comments on file 'trunk/src/dk/netarkivet/monitor/webinterface/JMXStatusEntry.java', revision 1165

Lines

Description

Classification

Status

319-320

Validate argument 'query'.

Cosmetic

OK

347-349

Missing argument validation in public method

Cosmetic

OK

IssuesFromNs126 (last edited 2010-08-16 10:24:47 by localhost)