= Review (NS-131): Bug 1846: Deploy the bitpreservation database =
|| Author || Jonas ||
|| Moderator || Jonas ||
|| State || Closed ||
== Objectives ==
{{{
Also ensure that the deploy unit tests works.
}}}
'''Total Time Used (Coding,Documentation,Review)''':

{{{
Time use (Coding,Documentation,Review)
JOLF: 1
HBK: 0.5
}}}
'''General comments''':
|| '''Description''' || '''Classification''' || '''Status''' ||


=== Comments on file 'trunk/src/dk/netarkivet/deploy/Machine.java', revision 1200 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| 94 || add @throws ArgumentNotValid and throws ArgumentNotValid method signature || Cosmetic || REJECT ||
|| 169 || Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature || Cosmetic || REJECT ||
|| 253 || Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature || Cosmetic || REJECT ||
|| 327 || Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature || Cosmetic || REJECT ||
|| 367 || Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature || Cosmetic || REJECT ||
|| 401 || Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature || Cosmetic || REJECT ||
|| 796 || Replace with: If no specific database is given in deploy file || Cosmetic || OK ||
=== Comments on file 'trunk/src/dk/netarkivet/deploy/LinuxMachine.java', revision 1200 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| 288 || Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature || Cosmetic ||REJECT ||
|| 348 || Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature || Cosmetic || REJECT ||
|| 420 || Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature || Cosmetic || REJECT ||
|| 525 || Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature || Cosmetic || REJECT ||
|| 615 || Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature || Cosmetic || REJECT ||
|| 725 || remove commented test code, and replace with proper comment about what is done. || Cosmetic || OK ||
|| 727 || remove commented test code. || Cosmetic || OK ||
|| 862 || check argument validness || Cosmetic || REJECT ||
|| 890 || check argument validness || Cosmetic || REJECT ||
|| 992 || check argument validness || Cosmetic || REJECT ||
|| 1133 || check argument validness || Cosmetic || REJECT ||
=== Comments on file 'trunk/src/dk/netarkivet/deploy/WindowsMachine.java', revision 1200 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| 347 || Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature || Cosmetic || REJECT ||
|| 393 || Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature || Cosmetic || REJECT ||
|| 479 || Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature || Cosmetic || REJECT ||
|| 581 || Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature || Cosmetic || REJECT ||
|| 599-600 || Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature || Cosmetic || REJECT ||
|| 648 || check arguements validness || Cosmetic || REJECT ||
|| 731 || check arguments validness || Cosmetic || REJECT ||
|| 840 || is there a FR/Bug for this? || Cosmetic || OK ||
|| 922 || check for argument validness || Cosmetic || REJECT ||
|| 951 || check for argument validness || Cosmetic || REJECT ||
|| 1054 || check for argument validness || Cosmetic || REJECT ||
|| 1115 || check for argument validness || Cosmetic || REJECT ||
|| 1339 || check for argument validness || Cosmetic || REJECT ||
=== Comments on file 'trunk/src/dk/netarkivet/deploy/Parameters.java', revision 1200 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| 61 || Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature || Cosmetic || OK ||
|| 80 || Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature || Cosmetic || OK ||
|| 115 || Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature || Cosmetic || OK ||
|| 118 || Rewrite comments || Cosmetic || OK ||
|| 118 || Should use system.out instead of log || Cosmetic || OK ||
|| 221 || or empty string if databaseDir is null. || Cosmetic || OK ||
=== Comments on file 'trunk/src/dk/netarkivet/deploy/DeployApplication.java', revision 1200 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| 441 || This should be changed so it checks whether it is a file (which also checks whether it exists). This might also occur at other initialization methods. || Cosmetic || OK ||
=== Comments on file 'trunk/src/dk/netarkivet/deploy/DeployConfiguration.java', revision 1200 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| 76 || Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature || Cosmetic || OK ||
=== Comments on file 'trunk/src/dk/netarkivet/deploy/ScriptConstants.java', revision 1200 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| 325 || add @throws ArgumentNotValid and throws ArgumentNotValid method signature || Cosmetic || OK ||
|| 335 || add @throws ArgumentNotValid and throws ArgumentNotValid method signature || Cosmetic || OK ||
|| 347 || add @throws ArgumentNotValid and throws ArgumentNotValid method signature || Cosmetic || OK ||
|| 361 || add @throws ArgumentNotValid and throws ArgumentNotValid method signature || Cosmetic || OK ||
|| 375 || add @throws ArgumentNotValid and throws ArgumentNotValid method signature || Cosmetic || OK ||
|| 388 || add @throws ArgumentNotValid and throws ArgumentNotValid method signature || Cosmetic || OK ||
|| 403 || Check arguments?  ArgumentNotValid || Minor || OK ||
=== Comments on file 'trunk/src/dk/netarkivet/deploy/PhysicalLocation.java', revision 1200 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| 82 || Add @throws ArgumentNotValid || Cosmetic || OK ||
|| 86 || Indent to match Above line Add throws ArgumentNotValid || Cosmetic || OK ||
|| 180 || Add @throws ArgumentNotValid || Cosmetic || OK ||
|| 182 || Add throws ArgumentNotValid || Cosmetic || OK ||
=== Comments on file 'trunk/src/dk/netarkivet/deploy/Constants.java', revision 1200 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| 500 || missing javadoc || Cosmetic ||OK ||
|| 544, 551, 561, 572 || Should these check given arguments? || Cosmetic || OK ||