Review (NS-131): Bug 1846: Deploy the bitpreservation database

Objectives

Also ensure that the deploy unit tests works.

Total Time Used (Coding,Documentation,Review):

Time use (Coding,Documentation,Review)
JOLF: 1
HBK: 0.5

General comments:

Description

Classification

Status

Lines	Description	Classification	Status
94	add @throws ArgumentNotValid and throws ArgumentNotValid method signature	Cosmetic	NOTOK
169	Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature	Cosmetic	NOTOK
253	Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature	Cosmetic	NOTOK
327	Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature	Cosmetic	NOTOK
367	Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature	Cosmetic	NOTOK
401	Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature	Cosmetic	NOTOK
796	Replace with: If no specific database is given in deploy file	Cosmetic	NOTOK

Lines	Description	Classification	Status
288	Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature	Cosmetic	NOTOK
348	Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature	Cosmetic	NOTOK
420	Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature	Cosmetic	NOTOK
525	Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature	Cosmetic	NOTOK
615	Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature	Cosmetic	NOTOK
725	remove commented test code, and replace with proper comment about what is done.	Cosmetic	NOTOK
727	remove commented test code.	Cosmetic	NOTOK
862	check argument validness	Cosmetic	NOTOK
890	check argument validness	Cosmetic	NOTOK
992	check argument validness	Cosmetic	NOTOK
1133	check argument validness	Cosmetic	NOTOK

Lines	Description	Classification	Status
347	Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature	Cosmetic	NOTOK
393	Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature	Cosmetic	NOTOK
479	Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature	Cosmetic	NOTOK
581	Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature	Cosmetic	NOTOK
599-600	Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature	Cosmetic	NOTOK
648	check arguements validness	Cosmetic	NOTOK
731	check arguments validness	Cosmetic	NOTOK
840	is there a FR/Bug for this?	Cosmetic	NOTOK
922	check for argument validness	Cosmetic	NOTOK
951	check for argument validness	Cosmetic	NOTOK
1054	check for argument validness	Cosmetic	NOTOK
1115	check for argument validness	Cosmetic	NOTOK
1339	check for argument validness	Cosmetic	NOTOK

Lines	Description	Classification	Status
61	Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature	Cosmetic	NOTOK
80	Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature	Cosmetic	NOTOK
115	Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature	Cosmetic	NOTOK
118	Rewrite comments	Cosmetic	NOTOK
118	Should use system.out instead of log	Cosmetic	NOTOK
221	or empty string if databaseDir is null.	Cosmetic	NOTOK

Lines	Description	Classification	Status
441	This should be changed so it checks whether it is a file (which also checks whether it exists). This might also occur at other initialization methods.	Cosmetic	NOTOK

Lines	Description	Classification	Status
76	Add @throws ArgumentNotValid and throws ArgumentNotValid to method signature	Cosmetic	NOTOK

Lines	Description	Classification	Status
325	add @throws ArgumentNotValid and throws ArgumentNotValid method signature	Cosmetic	NOTOK
335	add @throws ArgumentNotValid and throws ArgumentNotValid method signature	Cosmetic	NOTOK
347	add @throws ArgumentNotValid and throws ArgumentNotValid method signature	Cosmetic	NOTOK
361	add @throws ArgumentNotValid and throws ArgumentNotValid method signature	Cosmetic	NOTOK
375	add @throws ArgumentNotValid and throws ArgumentNotValid method signature	Cosmetic	NOTOK
388	add @throws ArgumentNotValid and throws ArgumentNotValid method signature	Cosmetic	NOTOK
403	Check arguments? ArgumentNotValid	Minor	NOTOK

Lines	Description	Classification	Status
82	Add @throws ArgumentNotValid	Cosmetic	NOTOK
86	Indent to match Above line Add throws ArgumentNotValid	Cosmetic	NOTOK
180	Add @throws ArgumentNotValid	Cosmetic	NOTOK
182	Add throws ArgumentNotValid	Cosmetic	NOTOK

Lines	Description	Classification	Status
500	missing javadoc	Cosmetic	NOTOK
544, 551, 561, 572	Should these check given arguments?	Cosmetic	NOTOK