Review (NS-135): Bug 1836: The value of the variable 'File from' must not be null.

Author

Jonas

Moderator

Jonas

State

Closed

Objectives

Total Time Used (Coding,Documentation,Review): 
Time use (Coding,Documentation,Review)
JOLF: 0.3
HBK: 0.1
General comments: 
  
 Description 

  
 Classification 

  
 Status 






Comments on file 'trunk/src/dk/netarkivet/archive/arcrepository/distribute/JMSArcRepositoryClient.java', revision 1208


  
 Lines 

  
 Description 

  
 Classification 

  
 Status 




  
 514 

  
 if sendAndWaitForOneReply is timing out then replyNetMsg is set to null, which means we throw an IOFailure. So we don't return null on timeout. 

  
 Cosmetic 

  
 OK 




  
 539-540 

  
 The last comment is incorrect. 

  
 Cosmetic 

  
 OK 




  
 574 

  
 if sendAndWaitForOneReply is timing out then replyNetMsg is set to null, which means we throw an IOFailure. So we don't return null on timeout. 

  
 Cosmetic 

  
 OK 




  
 600 

  
 The last comment is incorrect. 

  
 Cosmetic 

  
 OK 




  
 659 

  
 The last comment is incorrect. 

  
 Cosmetic 

  
 OK 




IssuesFromNs135  (last edited 2010-08-16 10:24:35 by localhost)