Differences between revisions 1 and 3 (spanning 2 versions)
⇤ ← Revision 1 as of 2010-02-04 12:41:18 →
Size: 1569
Editor: JonasFrellesen
Comment:
← Revision 3 as of 2010-08-16 10:24:38 → ⇥
Size: 1553
Editor: localhost
Comment: converted to 1.6 markup
Deletions are marked like this. Additions are marked like this.
Line 9: Line 9:
Line 13: Line 12:
{{{  {{{
Line 17: Line 16:
{{{ 
{{{
Line 22: Line 22:
Line 29: Line 28:
|| 414 || 'rep' should be changed to 'repName' to avoid confusion. || Cosmetic || NOTOK ||
|| 427-429 || Something wrong here: I think you meant: Can only send a batchjob to bitarchive replica and replica X is a Y type replica || Cosmetic || NOTOK ||		 || 414 || 'rep' should be changed to 'repName' to avoid confusion. || Cosmetic || OK ||
|| 427-429 || Something wrong here: I think you meant: Can only send a batchjob to bitarchive replica and replica X is a Y type replica || Cosmetic || OK ||
Line 33: Line 32:
|| 220 || add: "as a string array" || Cosmetic || NOTOK || || 220 || add: "as a string array" || Cosmetic || OK ||
Line 36: Line 35:
|| 170-186 || Change into an initialise method, or at least describe why this is done. || Cosmetic || NOTOK || || 170-186 || Change into an initialise method, or at least describe why this is done. || Cosmetic || OK ||

Review (NS-138): Bug 1727 and 1764: Poor RunBatch failure information

Author

Jonas

Moderator

Jonas

State

Closed

Objectives

Bug 1727: Poor error message in RunBatch
Bug 1764: Poor information on failed batch job
Test whether the new unit test for RunBatch works.

Summary

follow up by JOLF

Total Time Used (Coding,Documentation,Review): 

Time use (Coding,Documentation,Review)
SVC: 0.2
JOLF: 1.3

General comments:

Description

Classification

Status

Comments on file 'trunk/src/dk/netarkivet/archive/tools/RunBatch.java', revision 1215

Lines

Description

Classification

Status

414

'rep' should be changed to 'repName' to avoid confusion.

Cosmetic

OK

427-429

Something wrong here: I think you meant: Can only send a batchjob to bitarchive replica and replica X is a Y type replica

Cosmetic

OK

Comments on file 'trunk/src/dk/netarkivet/common/distribute/arcrepository/Replica.java', revision 1215

Lines

Description

Classification

Status

220

add: "as a string array"

Cosmetic

OK

Comments on file 'trunk/src/dk/netarkivet/common/utils/batch/LoadableJarBatchJob.java', revision 1215

Lines

Description

Classification

Status

170-186

Change into an initialise method, or at least describe why this is done.

Cosmetic

OK

IssuesFromNs138 (last edited 2010-08-16 10:24:38 by localhost)