= Review (NS-138): Bug 1727 and 1764: Poor RunBatch failure information =
|| Author || Jonas ||
|| Moderator || Jonas ||
|| State || Closed ||
== Objectives ==
{{{
Bug 1727: Poor error message in RunBatch
Bug 1764: Poor information on failed batch job
Test whether the new unit test for RunBatch works.
}}}
== Summary ==
{{{
follow up by JOLF
}}}
'''Total Time Used (Coding,Documentation,Review)''':

{{{
Time use (Coding,Documentation,Review)
SVC: 0.2
JOLF: 1.3
}}}
'''General comments''':
|| '''Description''' || '''Classification''' || '''Status''' ||


=== Comments on file 'trunk/src/dk/netarkivet/archive/tools/RunBatch.java', revision 1215 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| 414 || 'rep' should be changed to 'repName' to avoid confusion. || Cosmetic || OK ||
|| 427-429 || Something wrong here: I think you meant: Can only send a batchjob to bitarchive replica and replica X is a Y type replica || Cosmetic || OK ||
=== Comments on file 'trunk/src/dk/netarkivet/common/distribute/arcrepository/Replica.java', revision 1215 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| 220 || add: "as a string array" || Cosmetic || OK ||
=== Comments on file 'trunk/src/dk/netarkivet/common/utils/batch/LoadableJarBatchJob.java', revision 1215 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| 170-186 || Change into an initialise method, or at least describe why this is done. || Cosmetic || OK ||