Review (NS-140): Fixed FR1861 removed href="#" from code.
Author |
Henrik Kirk |
Moderator |
Henrik Kirk |
State |
Closed |
Objectives
1223: Fixed FR1861 removed href="#" from code.
Summary
Time use (Coding,Documentation,Review) JOLF: 0.1 HBK: 0.5
General comments:
Description |
Classification |
Status |
@param should say how the parameter is valid |
Cosmetic |
NOTOK |
Comments on file 'trunk/src/dk/netarkivet/monitor/webinterface/JMXSummaryUtils.java', revision 1223
Lines |
Description |
Classification |
Status |
116 |
add @throw ArgumentNotValid and throws ArgumentNotValid to method signature |
Cosmetic |
OK |
127 |
add @throw ArgumentNotValid and throws ArgumentNotValid to method signature |
Cosmetic |
OK |
144 |
add @throw ArgumentNotValid and throws ArgumentNotValid to method signature |
Cosmetic |
OK |
182 |
add @throw ArgumentNotValid and throws ArgumentNotValid to method signature |
Cosmetic |
OK |
206 |
add @throw ArgumentNotValid and throws ArgumentNotValid to method signature |
Cosmetic |
OK |
236 |
add @throw ArgumentNotValid and throws ArgumentNotValid to method signature |
Cosmetic |
OK |
260 |
add @throw ArgumentNotValid and throws ArgumentNotValid to method signature |
Cosmetic |
OK |
307 |
add throws ArgumentNotValid to method signature |
Cosmetic |
OK |
338 |
add @throw ArgumentNotValid and throws ArgumentNotValid to method signature |
Cosmetic |
OK |
340 |
Also add @throws ForwardedToErrorPage and throws ForwardedToErrorPage to method signature |
Cosmetic |
OK |
382-383 |
No argument validation? |
Cosmetic |
OK |
407 |
Should we check arguments? |
Cosmetic |
OK |
427-428 |
Is it a good idea to use random numbers? What would happen if two instances got the same id (even though it is very unlikely)? Made TODO note! |
Cosmetic |
OK |
464 |
add javadoc |
Cosmetic |
OK |
466 |
Add java doc |
Cosmetic |
OK |
480 |
add @throw ArgumentNotValid and throws ArgumentNotValid to method signature |
Cosmetic |
OK |
485 |
"value.length() == 0" should be replaced by value.isEmpty() |
Cosmetic |
OK |