= Review (NS-141): Fixed FR 1578 =
|| Author || Henrik Kirk ||
|| Moderator || Henrik Kirk ||
|| State || Closed ||
== Objectives ==
{{{
1224: Fixed FR 1578
}}}
== Summary ==
{{{ 
Time use (Coding,Documentation,Review) 
SVC: 0.1
HBK: 0.5
}}}
'''General comments''':
|| '''Description''' || '''Classification''' || '''Status''' ||


=== Comments on file 'trunk/src/dk/netarkivet/monitor/webinterface/JMXSummaryUtils.java', revision 1224 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| 108 || Missing '.' at the end of comment || Cosmetic || OK ||
|| 109 || Couldn't this be a setting? || Cosmetic || OK ||
|| 118 || Mention what validity means. Can the argument be empty string? || Cosmetic || OK ||
|| 132 || Mention what validity means. Can the argument be empty string? || Cosmetic || OK ||
|| 151 || Mention what validity means. Can the argument be empty string? || Cosmetic || OK ||
|| 191 || Mention what validity means. Can the argument be empty string? || Cosmetic || OK ||
|| 217 || Mention what validity means. Can the argument be empty string? || Cosmetic || OK ||
|| 350 || Mention what validity means. || Cosmetic || OK ||
|| 487 || Mention what validity means. || Cosmetic || OK ||
|| 504 || Mention what validity means. || Cosmetic || OK ||