Differences between revisions 1 and 6 (spanning 5 versions)
⇤ ← Revision 1 as of 2010-02-08 14:51:29 →
Size: 1784
Editor: SoerenCarlsen
Comment:
← Revision 6 as of 2010-08-16 10:24:44 → ⇥
Size: 1560
Editor: localhost
Comment: converted to 1.6 markup
Deletions are marked like this. Additions are marked like this.
Line 10: Line 10:
{{{  {{{
Line 14: Line 14:
{{{ 
{{{
Line 19: Line 20:
Line 24: Line 24:
=== Comments on file 'trunk/tests/dk/netarkivet/harvester/datamodel/HarvestTemplateApplicationTester.java', revision 1260 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
Line 28: Line 26:
|| 27 || Why has this extra line been added? || Cosmetic || NOTOK || || 27 || Why has this extra line been added? || Cosmetic || OK ||
Line 31: Line 29:
|| 54 || Java-doc. Does not say what this function does. || Cosmetic || NOTOK || || 54 || Java-doc. Does not say what this function does. || Cosmetic || OK ||
Line 34: Line 32:
|| 34-49 || Java-doc || Cosmetic || NOTOK ||
|| 46 || Add to javadoc: This will not be allowed by the default Java Security Policy. || Cosmetic || NOTOK ||		 || 34-49 || Java-doc || Cosmetic || OK ||
|| 46 || Add to javadoc: This will not be allowed by the default Java Security Policy. || Cosmetic || OK ||
Line 38: Line 36:
|| 46 || Finish javadoc || Cosmetic || NOTOK || || 46 || Finish javadoc || Cosmetic || OK ||

Review (NS-146): Miscellaneous refactoring of code

Author

Søren

Moderator

Søren

State

Closed

Objectives

Review miscellaneous refactoring of code

Summary

Review completed; followup by SVC

Total Time Used (Coding,Documentation,Review): 

Time use (Coding,Documentation,Review)
SVC: 0.5
JOLF: 0.1

General comments:

Description

Classification

Status

Comments on file 'trunk/src/dk/netarkivet/common/tools/JMSBroker.java', revision 1259

Lines

Description

Classification

Status

27

Why has this extra line been added?

Cosmetic

OK

Comments on file 'trunk/src/dk/netarkivet/harvester/tools/HarvestTemplateApplication.java', revision 1260

Lines

Description

Classification

Status

54

Java-doc. Does not say what this function does.

Cosmetic

OK

Comments on file 'trunk/src/dk/netarkivet/common/utils/batch/FileRemover.java', revision 1262

Lines

Description

Classification

Status

34-49

Java-doc

Cosmetic

OK

46

Add to javadoc: This will not be allowed by the default Java Security Policy.

Cosmetic

OK

Comments on file 'trunk/src/dk/netarkivet/common/tools/WriteBytesToFile.java', revision 1260

Lines

Description

Classification

Status

46

Finish javadoc

Cosmetic

OK

IssuesFromNs146 (last edited 2010-08-16 10:24:44 by localhost)