NetarchiveSuite|
Size: 1577
Comment:
|
Size: 1569
Comment:
|
| Deletions are marked like this. | Additions are marked like this. |
| Line 10: | Line 10: |
| {{{ | {{{ |
| Line 14: | Line 14: |
| {{{ | {{{ |
| Line 19: | Line 20: |
| Line 32: | Line 32: |
| || 34-49 || Java-doc || Cosmetic || NOTOK || || 46 || Add to javadoc: This will not be allowed by the default Java Security Policy. || Cosmetic || NOTOK || |
|| 34-49 || Java-doc || Cosmetic || OK || || 46 || Add to javadoc: This will not be allowed by the default Java Security Policy. || Cosmetic || OK || |
Review (NS-146): Miscellaneous refactoring of code
Author |
Søren |
Moderator |
Søren |
State |
Closed |
Objectives
Review miscellaneous refactoring of code
Summary
Review completed; followup by SVC
Total Time Used (Coding,Documentation,Review):
Time use (Coding,Documentation,Review) SVC: 0.5 JOLF: 0.1
General comments:
Description |
Classification |
Status |
Comments on file 'trunk/src/dk/netarkivet/common/tools/JMSBroker.java', revision 1259
Lines |
Description |
Classification |
Status |
27 |
Why has this extra line been added? |
Cosmetic |
NOTOK |
Comments on file 'trunk/src/dk/netarkivet/harvester/tools/HarvestTemplateApplication.java', revision 1260
Lines |
Description |
Classification |
Status |
54 |
Java-doc. Does not say what this function does. |
Cosmetic |
NOTOK |
Comments on file 'trunk/src/dk/netarkivet/common/utils/batch/FileRemover.java', revision 1262
Lines |
Description |
Classification |
Status |
34-49 |
Java-doc |
Cosmetic |
OK |
46 |
Add to javadoc: This will not be allowed by the default Java Security Policy. |
Cosmetic |
OK |
Comments on file 'trunk/src/dk/netarkivet/common/tools/WriteBytesToFile.java', revision 1260
Lines |
Description |
Classification |
Status |
46 |
Finish javadoc |
Cosmetic |
NOTOK |