2575
Comment:
|
← Revision 3 as of 2010-08-16 10:24:59 ⇥
2528
converted to 1.6 markup
|
Deletions are marked like this. | Additions are marked like this. |
Line 7: | Line 7: |
Line 10: | Line 9: |
{{{ | {{{ |
Line 15: | Line 15: |
Line 22: | Line 21: |
|| 1095 || log.debug! || Cosmetic || NOTOK || || 1186 || Send a notification here about this issue. || Cosmetic || NOTOK || || 1316 || Log here when the tmpChecksum value is null (and why it probably is null) || Cosmetic || NOTOK || || 1332 || spelling: unanious => unanimous || Cosmetic || NOTOK || || 1341 || Log here when the cs value is null (and why it probably is null) || Cosmetic || NOTOK || || 1704 || Validate argument (not null and not empty) || Cosmetic || NOTOK || || 2227 || add: can be null || Cosmetic || NOTOK || || 2267 || log and then throw exception || Cosmetic || NOTOK || || 2268 || Add "finally" clause containing statement (requires that stmt is initialized to null outside of the try-catch): DBUtils.closeStatementIfOpen(stmt); || Cosmetic || NOTOK || |
|| 1095 || log.debug! || Cosmetic || OK || || 1186 || Send a notification here about this issue. || Cosmetic || OK || || 1316 || Log here when the tmpChecksum value is null (and why it probably is null) || Cosmetic || OK || || 1332 || spelling: unanious => unanimous || Cosmetic || OK || || 1341 || Log here when the cs value is null (and why it probably is null) || Cosmetic || OK || || 1704 || Validate argument (not null and not empty) || Cosmetic || OK || || 2227 || add: can be null || Cosmetic || OK || || 2267 || log and then throw exception || Cosmetic || REJECT || || 2268 || Add "finally" clause containing statement (requires that stmt is initialized to null outside of the try-catch): DBUtils.closeStatementIfOpen(stmt); || Cosmetic || OK || |
Line 33: | Line 32: |
|| 158 || Describe what happens if there is no winner of the 'voting'. || Cosmetic || NOTOK || || 176-177 || Verify that statement starting with "it is verified .." is correct, or should be deleted || Cosmetic || NOTOK || || 183 || Change to updateSingleChecksumResult(...) || Cosmetic || NOTOK || || 183 || Method should properly be renamed to something prefixed with "update": UpdateChecksumInformationForFileOnReplica || Cosmetic || NOTOK || |
|| 158 || Describe what happens if there is no winner of the 'voting'. || Cosmetic || OK || || 176-177 || Verify that statement starting with "it is verified .." is correct, or should be deleted || Cosmetic || OK || || 183 || Change to updateSingleChecksumResult(...) || Cosmetic || OK || || 183 || Method should properly be renamed to something prefixed with "update": UpdateChecksumInformationForFileOnReplica || Cosmetic || OK || |
Line 39: | Line 38: |
|| 183-184 || Change to: Update the checksum status for this file in the database Change command to cache.updateChecksumStatus(filename) || Cosmetic || NOTOK || || 260 || Remove unused parameter || Cosmetic || NOTOK || || 266-268 || instantiate the ArcRepositoryClient outside the loop || Cosmetic || NOTOK || |
|| 183-184 || Change to: Update the checksum status for this file in the database Change command to cache.updateChecksumStatus(filename) || Cosmetic || OK || || 260 || Remove unused parameter || Cosmetic || OK || || 266-268 || instantiate the ArcRepositoryClient outside the loop || Cosmetic || OK || |
Review (NS-158): Bug 1986: DatabasePreserveState does not update correct
Author |
Jonas |
Moderator |
Jonas |
State |
Closed |
Objectives
Total Time Used (Coding,Documentation,Review):
Time use (Coding,Documentation,Review) JOLF: 1.5 SVC: 0.2
General comments:
Description |
Classification |
Status |
Comments on file 'trunk/src/dk/netarkivet/archive/arcrepositoryadmin/ReplicaCacheDatabase.java', revision 1456
Lines |
Description |
Classification |
Status |
1095 |
log.debug! |
Cosmetic |
OK |
1186 |
Send a notification here about this issue. |
Cosmetic |
OK |
1316 |
Log here when the tmpChecksum value is null (and why it probably is null) |
Cosmetic |
OK |
1332 |
spelling: unanious => unanimous |
Cosmetic |
OK |
1341 |
Log here when the cs value is null (and why it probably is null) |
Cosmetic |
OK |
1704 |
Validate argument (not null and not empty) |
Cosmetic |
OK |
2227 |
add: can be null |
Cosmetic |
OK |
2267 |
log and then throw exception |
Cosmetic |
REJECT |
2268 |
Add "finally" clause containing statement (requires that stmt is initialized to null outside of the try-catch): DBUtils.closeStatementIfOpen(stmt); |
Cosmetic |
OK |
Comments on file 'trunk/src/dk/netarkivet/archive/arcrepositoryadmin/BitPreservationDAO.java', revision 1454
Lines |
Description |
Classification |
Status |
158 |
Describe what happens if there is no winner of the 'voting'. |
Cosmetic |
OK |
176-177 |
Verify that statement starting with "it is verified .." is correct, or should be deleted |
Cosmetic |
OK |
183 |
Change to updateSingleChecksumResult(...) |
Cosmetic |
OK |
183 |
Method should properly be renamed to something prefixed with "update": UpdateChecksumInformationForFileOnReplica |
Cosmetic |
OK |
Comments on file 'trunk/src/dk/netarkivet/archive/arcrepository/bitpreservation/DatabaseBasedActiveBitPreservation.java', revision 1454
Lines |
Description |
Classification |
Status |
183-184 |
Change to: Update the checksum status for this file in the database Change command to cache.updateChecksumStatus(filename) |
Cosmetic |
OK |
260 |
Remove unused parameter |
Cosmetic |
OK |
266-268 |
instantiate the ArcRepositoryClient outside the loop |
Cosmetic |
OK |