Differences between revisions 1 and 3 (spanning 2 versions)
⇤ ← Revision 1 as of 2009-06-11 11:36:50 →
Size: 1659
Editor: SoerenCarlsen
Comment:
← Revision 3 as of 2010-08-16 10:24:39 → ⇥
Size: 1650
Editor: localhost
Comment: converted to 1.6 markup
Deletions are marked like this. Additions are marked like this.
Line 17: Line 17:
Line 24: Line 25:

Line 26: Line 29:
|| 261 || Add that "By default there is no additional JVM options" || Cosmetic || NOTOK ||
|| 264 || Remove tab || Cosmetic || NOTOK ||		 || 261 || Add that "By default there is no additional JVM options" || Cosmetic || OK ||
|| 264 || Remove tab || Cosmetic || OK ||
Line 30: Line 33:
|| General || The tabs in many of the added should be replaced by spaces || Cosmetic || NOTOK ||
|| 256 || Remove unused line || Cosmetic || NOTOK ||
|| 289-290 || Move a local variable for allOpts.toArray(new String[allOpts.size())]], so we can fix feature request 1227 (Log the Heritrix command line) right now by including a log.info: "Starting Heritrix process with args" + args; || Cosmetic || NOTOK ||		 || General || The tabs in many of the added should be replaced by spaces || Cosmetic || OK ||
|| 256 || Remove unused line || Cosmetic || OK ||
|| 289-290 || Move a local variable for allOpts.toArray(new String[allOpts.size())]], so we can fix feature request 1227 (Log the Heritrix command line) right now by including a log.info: "Starting Heritrix process with args" + args; || Cosmetic || OK ||

Review (NS-45): Review of FR 1628: Add custom JVM parameters to Heritrix subproces

Author

Søren

Moderator

Søren

State

Closed

Objectives

Review of files:
/trunk/src/dk/netarkivet/harvester/harvesting/JMXHeritrixController.java, revision 839, lines 251-291
/trunk/src/dk/netarkivet/harvester/HarvesterSettings.java, revision 839, lines 258-264
/trunk/src/dk/netarkivet/harvester/settings.xml, revision 839, lines 71

Summary

follow-up by ngiraud

Total Time Used (Coding,Documentation,Review): 

Time use (Coding,Documentation,Review)
NGiraud: 0.5
SVC: 0.5

General comments:

Description

Classification

Status

Comments on file 'trunk/src/dk/netarkivet/harvester/HarvesterSettings.java', revision 839

Lines

Description

Classification

Status

261

Add that "By default there is no additional JVM options"

Cosmetic

OK

264

Remove tab

Cosmetic

OK

Comments on file 'trunk/src/dk/netarkivet/harvester/harvesting/JMXHeritrixController.java', revision 839

Lines

Description

Classification

Status

General

The tabs in many of the added should be replaced by spaces

Cosmetic

OK

256

Remove unused line

Cosmetic

OK

289-290

Move a local variable for allOpts.toArray(new String[allOpts.size())]], so we can fix feature request 1227 (Log the Heritrix command line) right now by including a log.info: "Starting Heritrix process with args" + args;

Cosmetic

OK

IssuesFromNs45 (last edited 2010-08-16 10:24:39 by localhost)