= Review (NS-47): Review fix of Bug 1524: Database connections to MySQL close down intermittently =
|| Author || Søren ||
|| Moderator || Søren ||
|| State || Closed ||
== Objectives ==
{{{
Review of files:
/trunk/src/dk/netarkivet/harvester/datamodel/DBConnect.java, revision 837, lines  56-100
/trunk/src/dk/netarkivet/common/settings.xml, revision 837, lines 401
/trunk/src/dk/netarkivet/common/CommonSettings.java, revision 837, lines 240-246
}}}
== Summary ==
{{{
Followup by Nicolas Giraud
}}}
'''Total Time Used (Coding,Documentation,Review)''':

{{{
Time use (Coding,Documentation,Review)
NGiraud: 2 md
SVC: 2 md
}}}
'''General comments''':
|| '''Description''' || '''Classification''' || '''Status''' ||


=== Comments on file 'trunk/src/dk/netarkivet/harvester/datamodel/DBConnect.java', revision 837 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| General || Shorten lines longer than 80 characters. Note that we don't respect this in our fileheaders, and in our unittest-code || Cosmetic || OK ||
|| General || remove tabs from file || Cosmetic || OK ||
|| General || Add to javadoc for the getDBConnection, that the connections are now renewed, if they are no longer alive || Cosmetic || OK ||
=== Comments on file 'trunk/src/dk/netarkivet/common/CommonSettings.java', revision 837 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| 242-243 || What are this timeout used for? And what does the default of 0 seconds signify? || Cosmetic || OK ||