Review (NS-48): Review of the fixes for the minor bugs (1611, 1636, 1646)

Author	Søren
Moderator	Søren
State	Closed

Objectives

Check, that bug 1611 is fixed by verifying the changes to file:
 /trunk/src/dk/netarkivet/harvester/webinterface/DefinitionsSiteSection.java, revision 828
Check, that bug 1636 is fixed by verifying the changes to files:
/trunk/src/dk/netarkivet/common/utils/batch/LoadableJarBatchJob.jar, revision 829
/trunk/src/dk/netarkivet/common/distribute/indexserver/JobIndexCache.java,  revision 829
/trunk/src/dk/netarkivet/archive/indexserver/CrawlLogIndexCache.java, revision 829
/trunk/src/dk/netarkivet/harvester/harvesting/JMXHeritrixController.java, revision 829
/trunk/src/dk/netarkivet/harvester/harvesting/DirectHeritrixController.java , revision 829
/trunk/src/dk/netarkivet/harvester/datamodel/JobDBDAO.java , revision 829
Check, that bug 1646 is fixed by verifying the changes to file:
/trunk/src/dk/netarkivet/harvester/harvesting/distribute/MetadataEntry.java, revision 830

Summary

Review completed, followup by SVC

General comments:

Description

Classification

Status

Comments on file 'trunk/src/dk/netarkivet/harvester/harvesting/JMXHeritrixController.java', revision 829

Lines	Description	Classification	Status
816-818	Why use 3 line on something, which does only require 2? E.g. change to: log.debug("The JMX username used for connecting to " + "the Heritrix GUI is: '" + jmxUsername + "'.");	Cosmetic	OK