= Review (NS-49): Review of FR [[#1675]] List of all Seeds of a selective Harvests =
|| Author || Søren ||
|| Moderator || Søren ||
|| State || Closed ||
== Objectives ==
{{{
Review files:
/trunk/src/dk/netarkivet/harvester/Translations.properties, revision 833, lines 325-328
/trunk/src/dk/netarkivet/harvester/datamodel/HarvestDefinitionDAO.java, revision 833, lines 410-427
/trunk/src/dk/netarkivet/harvester/datamodel/HarvestDefinitionDBDAO.java,revision 833, 1093-1201
/trunk/webpages/History/Harveststatus-seeds.jsp,revision 833
/trunk/tests/dk/netarkivet/harvester/datamodel/SeedListTester.java, revision 833
/trunk/webpages/HarvestDefinition/Definitions-selective-harvests.jsp, revision 833
}}}
== Summary ==
{{{
Review completed, Andreas makes followup
}}}
'''General comments''':
|| '''Description''' || '''Classification''' || '''Status''' ||
|| We need danish and german translations for these new translations:
harvestdefinition.linktext.seeds=Seeds
harveststatus.seeds.total=Total
harveststatus.seeds.domains=Domains
harveststatus.seeds.seeds=Seeds
Andreas will add keys to the danish and german translation files || Cosmetic || NOTOK ||
|| Fix long lines, and remove tabs || Cosmetic || NOTOK ||
=== Comments on file 'trunk/src/dk/netarkivet/harvester/datamodel/HarvestDefinitionDBDAO.java', revision 833 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| 1195-1196 || Checkstyle complains about "+" at the end of line || Cosmetic || NOTOK ||
=== Comments on file 'trunk/webpages/History/Harveststatus-seeds.jsp', revision 833 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| General || fileheader missing. See the coding-guidelines: http://netarchive.dk/suite/Development#GuidelinesAndPolicies || Cosmetic || NOTOK ||
=== Comments on file 'trunk/tests/dk/netarkivet/harvester/datamodel/SeedListTester.java', revision 833 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| General || fileheader missing. See the coding-guidelines: http://netarchive.dk/suite/Development#GuidelinesAndPolicies || Cosmetic || NOTOK ||
=== Comments on file 'trunk/webpages/HarvestDefinition/Definitions-selective-harvests.jsp', revision 833 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| General || Maybe we should have this percentage as a java constant, and then refer to it, like we already  for the nextdate above || Cosmetic || NOTOK ||
=== Comments on file 'trunk/src/dk/netarkivet/harvester/datamodel/HarvestDefinitionDAO.java', revision 833 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| 412, 421 || "@param name of HarvestDefinition" => "@param harvestName name of HarvestDefinition" || Cosmetic || NOTOK ||