Differences between revisions 3 and 4

Review (NS-50): Bug 1711: Kill HeritrixController if Heritrix fails to shutdown

Objectives

Total Time Used (Coding,Documentation,Review):

Time use (Coding,Documentation,Review)
kfc: 0.1,0,0.1
csr: 0,0,0.1

General comments:

Description

Classification

Status

Lines	Description	Classification	Status
General	We don't know if destroy() sends a kill or a kill -9, so in theory we could try issuing a kill -9 here. There doesn't seem to be anything in the Process API for getting the PID. I suggest a feature request to pull out the pid so that we can a) try a kill -9 and b) log the process id if that fails	Minor	OK
547	Should this not be log.fatal? By definition a fatal error is one from which the application cannot recover.	Minor	NOTOK
556	If possible, pull out PID of Heritrix process.	Cosmetic	Rejected
681	heritrixProcess has no toString	Cosmetic	Rejected

⇤ ← Revision 3 as of 2009-06-30 11:56:26 → Size: 1238 Editor: KaareChristiansen Comment:	← Revision 4 as of 2010-08-16 10:24:52 → ⇥ Size: 1238 Editor: localhost Comment: converted to 1.6 markup
No differences found!