= Review (NS-50): Bug 1711: Kill HeritrixController if Heritrix fails to shutdown =
|| Author || Kåre ||
|| Moderator || Kåre ||
|| State || Closed ||
== Objectives ==
{{{

}}}
'''Total Time Used (Coding,Documentation,Review)''':
{{{ 
Time use (Coding,Documentation,Review)
kfc: 0.1,0,0.1
csr: 0,0,0.1
}}}

'''General comments''':
|| '''Description''' || '''Classification''' || '''Status''' ||


=== Comments on file 'trunk/src/dk/netarkivet/harvester/harvesting/JMXHeritrixController.java', revision 852 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| General || We don't know if destroy() sends a kill or a kill -9, so in theory we could try issuing a kill -9 here. There doesn't seem to be anything in the Process API for getting the PID. I suggest a feature request to pull out the pid so that we can a) try a kill -9 and b) log the process id if that fails || Minor || OK ||
|| 547 || Should this not be log.fatal? By definition a fatal error is one from which the application cannot recover. || Minor || NOTOK ||
|| 556 || If possible, pull out PID of Heritrix process. || Cosmetic || Rejected ||
|| 681 || heritrixProcess has no toString || Cosmetic || Rejected ||