Review (NS-50): Bug 1711: Kill HeritrixController if Heritrix fails to shutdown

Author

kfc

Moderator

kfc

State

Closed

Objectives

Total Time Used (Coding,Documentation,Review): 
Time use (Coding,Documentation,Review)
kfc: 0.1,0,0.1
csr: 0,0,0.1
General comments: 
  
 Description 

  
 Classification 

  
 Status 






Comments on file 'trunk/src/dk/netarkivet/harvester/harvesting/JMXHeritrixController.java', revision 852


  
 Lines 

  
 Description 

  
 Classification 

  
 Status 




  
 547 

  
 Should this not be log.fatal? By definition a fatal error is one from which the application cannot recover. 

  
 Minor 

  
 NOTOK 




  
 556 

  
 If possible, pull out PID of Heritrix process. 

  
 Cosmetic 

  
 NOTOK 




  
 681 

  
 heritrixProcess has no toString 

  
 Cosmetic 

  
 NOTOK