= Review (NS-55): Fix for bug #928, we are using HarvesterSettings.MAX_DOMAIN_SIZE... =
|| Author || Henrik Kirk ||
|| Moderator || Henrik Kirk ||
|| State || Closed ||
== Objectives ==
{{{
866: Fix for bug #928, we are using HarvesterSettings.MAX_DOMAIN_SIZE directly instead of calculating the excepted number of object if we havn't harvested this domain before.
}}}
'''General comments''':
|| '''Description''' || '''Classification''' || '''Status''' ||


=== Comments on file 'trunk/src/dk/netarkivet/harvester/datamodel/DomainConfiguration.java', revision 880 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| 45 || Extra spaces in front of class name || Cosmetic || NOTOK ||
|| 53 || First sentence of javadoc must end with a period || Cosmetic || NOTOK ||
|| 68-70 || First sentence of javadoc must end with a period || Cosmetic || NOTOK ||
|| 72 || First sentence of javadoc must end with a period || Cosmetic || NOTOK ||
|| 96 || Casting long to int can cause strange problems. Is it possible to check whether or not this cast will actually the value of this.maxObjects || Cosmetic || NOTOK ||
|| 107 || Change "filename" to "ordername" || Cosmetic || NOTOK ||
|| 119 || Add to msg: ", but was " + max || Cosmetic || NOTOK ||
|| 163 || Missing javadoc for getComments() method || Cosmetic || NOTOK ||
|| 256 || Add missing javadoc || Cosmetic || NOTOK ||
|| 268-275 || This javadoc does not say ANYTHING about what is meant by best-expectation. According to the code in line 288-289,294-295 and the comment in 280-281, this should mean: The most recent harvest of the domain, where the domain was fully harvested???? || Cosmetic || NOTOK ||
|| 309 || Change "0" to a reference to Constants.HERITRIX_MAXOBJECTS_INFINITY || Cosmetic || NOTOK ||
|| 316 || Change "-1" to a reference to Constants.HERITRIX_MAXBYTES_INFINITY || Cosmetic || NOTOK ||
|| 354-363 || Remove long lines || Cosmetic || NOTOK ||
|| 360 || This variable is never used. || Cosmetic || NOTOK ||
|| 361 || Change "stoppede" to "stopped" || Cosmetic || NOTOK ||
|| 393 || inifite => infinite || Cosmetic || NOTOK ||
|| 393 || Change -1 to a reference to the constant used in the code || Cosmetic || NOTOK ||
|| 431 || Change variable "default_expectation" to "defaultExpectation" || Cosmetic || NOTOK ||
|| 452 || ArgumentNotValid check missing for argument comments || Cosmetic || NOTOK ||
|| 477 || ArgumentNotValid check missing for argument passwordName || Cosmetic || NOTOK ||
|| 534 || Add missing javadoc || Cosmetic || NOTOK ||