= Review (NS-57): Added feature request for 1014. Added a private method on... =
|| Author || Henrik Kirk ||
|| Moderator || Henrik Kirk ||
|| State || Closed ||
== Objectives ==
{{{
870:
Added feature request for 1014. Added a private method on HarvestScheduler stopOldJobs.
When to stop a job is determined by a jobs AtualStartTime and the timeout time is determined by settings.harvester.scheduler.jobtimeouttime. Standard is set to 604800 seconds equal one week.
Added a testStopOldJobs in HarvestSchedulerTester which testes that HarvestScheduler.run() marks started jobs as failed if they are older than one week.
Cleaned up in warnings
}}}
'''General comments''':
|| '''Description''' || '''Classification''' || '''Status''' ||


=== Comments on file 'trunk/src/dk/netarkivet/harvester/HarvesterSettings.java', revision 870 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| 153 || Replace ';' with '.' ||Cosmetic || OK ||
=== Comments on file 'trunk/tests/dk/netarkivet/harvester/scheduler/HarvestSchedulerTester.java', revision 870 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||

=== Comments on file 'trunk/src/dk/netarkivet/harvester/scheduler/HarvestScheduler.java', revision 870 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| 162 || Rename as stopTimeoutJobs() || Cosmetic || OK ||
|| 201 || Change to "Stop any job that has been in status STARTED a very long time defined by the HarvesterSettings.JOB_TIMEOUT_TIME setting" || Cosmetic || OK ||
|| 215 || Remove comment || Cosmetic || OK ||
|| 217 || Change to: " Job " + id + " has exceeded its timeout of XXX minutes. Its status has now been changed to FAILED." || Cosmetic || OK ||