Differences between revisions 1 and 3 (spanning 2 versions)
⇤ ← Revision 1 as of 2009-07-29 16:48:05 →
Size: 3639
Editor: SoerenCarlsen
Comment:
← Revision 3 as of 2010-08-16 10:24:28 → ⇥
Size: 3562
Editor: localhost
Comment: converted to 1.6 markup
Deletions are marked like this. Additions are marked like this.
Line 7: Line 7:
Line 10: Line 9:
{{{  {{{
Line 20: Line 19:
|| General || Missing subversion keys || Cosmetic || NOTOK ||
|| 29-30 || Wrong class javadoc || Cosmetic || NOTOK ||		 || General || Missing subversion keys || Cosmetic || OK ||
|| 29-30 || Wrong class javadoc || Cosmetic || OK ||
Line 24: Line 23:
|| General || Missing subversion keys || Cosmetic || NOTOK ||
|| 50 || File f || Cosmetic || NOTOK ||		 || General || Missing subversion keys || Cosmetic || OK ||
|| 50 || File f || Cosmetic || OK ||
Line 28: Line 27:
|| 119 || . || Cosmetic || NOTOK ||
|| 138 || . || Cosmetic || NOTOK ||
|| 152 || . || Cosmetic || NOTOK ||
|| 190 || . || Cosmetic || NOTOK ||		 || 119 || . || Cosmetic || OK ||
|| 138 || . || Cosmetic || OK ||
|| 152 || . || Cosmetic || OK ||
|| 190 || . || Cosmetic || OK ||
Line 34: Line 33:
|| General || Missing subversion keys || Cosmetic || NOTOK ||
|| General || Why not change this abstract class to an interface || Cosmetic || NOTOK ||		 || General || Missing subversion keys || Cosmetic || OK ||
|| General || Why not change this abstract class to an interface || Cosmetic || OK ||
Line 38: Line 37:
|| 686, 690 || FreeSpaceCalculation class => FreeSpaceProvider class defined by the setting CommonSettings.FREE_SPACE_PROVIDER_CLASS (a.k.a settings.common.freespaceprovider.class) || Cosmetic || NOTOK ||
|| 690 || defined in settinds.xml. || Cosmetic || NOTOK ||		 || 686, 690 || FreeSpaceCalculation class => FreeSpaceProvider class defined by the setting CommonSettings.FREE_SPACE_PROVIDER_CLASS (a.k.a settings.common.freespaceprovider.class) || Cosmetic || OK ||
|| 690 || defined in settinds.xml. || Cosmetic || OK ||
Line 42: Line 41:
|| General || Missing subversion keys || Cosmetic || NOTOK || || General || Missing subversion keys || Cosmetic || OK ||
Line 45: Line 44:
|| 348-349 || ... utils.FreeSpaceProvider.
 */ || Cosmetic || NOTOK ||
|| 350 || Change tp FREESPACE_PROVIDER_CLASS || Cosmetic || NOTOK ||		 || 348-349 || ... utils.FreeSpaceProvider || Cosmetic || OK ||
|| 350 || Change to FREESPACE_PROVIDER_CLASS || Cosmetic || OK ||
Line 50: Line 48:
|| General || Missing subversion keys || Cosmetic || NOTOK ||
|| 40 || Should be renamed FilebasedFreeSpaceProvider || Cosmetic || NOTOK ||
|| 74 || name as parameter f. || Cosmetic || NOTOK ||
|| 81 || Second parameter: "File f" || Cosmetic || NOTOK ||
|| 92 || While loop overwrites bytes for every line, is this the wanted result, shouldn't it either bytes += Long.parseLong() or only read one line? || Minor || NOTOK ||		 || General || Missing subversion keys || Cosmetic || OK ||
|| 40 || Should be renamed FilebasedFreeSpaceProvider || Cosmetic || OK ||
|| 74 || name as parameter f. || Cosmetic || OK ||
|| 81 || Second parameter: "File f" || Cosmetic || OK ||
|| 92 || While loop overwrites bytes for every line, is this the wanted result, shouldn't it either bytes += Long.parseLong() or only read one line? || Minor || OK ||
Line 57: Line 55:
|| General || Missing subversion keys || Cosmetic || NOTOK ||
|| General || Move to the tests/dk/netarkivet/common/utils/ || Cosmetic || NOTOK ||
 || General || Missing subversion keys || Cosmetic || OK ||
|| General || Move to the tests/dk/netarkivet/common/utils/ || Cosmetic || OK ||

Review (NS-60): FR 1709

Author

ONB

Moderator

Søren

State

Closed

Objectives



Summary


Andreas has already acted on most of the defects reported by Henrik and I (Søren).
The remaining followup needed will be done by Andreas and/or Søren
General comments: 
  
 Description 

  
 Classification 

  
 Status 






Comments on file 'trunk/src/dk/netarkivet/common/utils/FreeSpaceProviderFactory.java', revision 892


  
 Lines 

  
 Description 

  
 Classification 

  
 Status 




  
 General 

  
 Missing subversion keys 

  
 Cosmetic 

  
 OK 




  
 29-30 

  
 Wrong class javadoc 

  
 Cosmetic 

  
 OK 






Comments on file 'trunk/src/dk/netarkivet/common/utils/DefaultFreeSpaceProvider.java', revision 892


  
 Lines 

  
 Description 

  
 Classification 

  
 Status 




  
 General 

  
 Missing subversion keys 

  
 Cosmetic 

  
 OK 




  
 50 

  
 File f 

  
 Cosmetic 

  
 OK 






Comments on file 'trunk/tests/dk/netarkivet/archive/bitarchive/IntegrityTests.java', revision 892


  
 Lines 

  
 Description 

  
 Classification 

  
 Status 




  
 119 

  
 . 

  
 Cosmetic 

  
 OK 




  
 138 

  
 . 

  
 Cosmetic 

  
 OK 




  
 152 

  
 . 

  
 Cosmetic 

  
 OK 




  
 190 

  
 . 

  
 Cosmetic 

  
 OK 






Comments on file 'trunk/src/dk/netarkivet/common/utils/FreeSpaceProvider.java', revision 892


  
 Lines 

  
 Description 

  
 Classification 

  
 Status 




  
 General 

  
 Missing subversion keys 

  
 Cosmetic 

  
 OK 




  
 General 

  
 Why not change this abstract class to an interface 

  
 Cosmetic 

  
 OK 






Comments on file 'trunk/src/dk/netarkivet/common/utils/FileUtils.java', revision 892


  
 Lines 

  
 Description 

  
 Classification 

  
 Status 




  
 686, 690 

  
 FreeSpaceCalculation class => FreeSpaceProvider class defined by the setting CommonSettings.FREE_SPACE_PROVIDER_CLASS (a.k.a settings.common.freespaceprovider.class) 

  
 Cosmetic 

  
 OK 




  
 690 

  
 defined in settinds.xml. 

  
 Cosmetic 

  
 OK 






Comments on file 'trunk/src/dk/netarkivet/common/utils/FileFreeSpaceProviderSettings.xml', revision 892


  
 Lines 

  
 Description 

  
 Classification 

  
 Status 




  
 General 

  
 Missing subversion keys 

  
 Cosmetic 

  
 OK 






Comments on file 'trunk/src/dk/netarkivet/common/CommonSettings.java', revision 892


  
 Lines 

  
 Description 

  
 Classification 

  
 Status 




  
 348-349 

  
 ... utils.FreeSpaceProvider 

  
 Cosmetic 

  
 OK 




  
 350 

  
 Change to FREESPACE_PROVIDER_CLASS 

  
 Cosmetic 

  
 OK 






Comments on file 'trunk/src/dk/netarkivet/common/utils/FileFreeSpaceProvider.java', revision 892


  
 Lines 

  
 Description 

  
 Classification 

  
 Status 




  
 General 

  
 Missing subversion keys 

  
 Cosmetic 

  
 OK 




  
 40 

  
 Should be renamed FilebasedFreeSpaceProvider 

  
 Cosmetic 

  
 OK 




  
 74 

  
 name as parameter f. 

  
 Cosmetic 

  
 OK 




  
 81 

  
 Second parameter: "File f" 

  
 Cosmetic 

  
 OK 




  
 92 

  
 While loop overwrites bytes for every line, is this the wanted result, shouldn't it either bytes += Long.parseLong() or only read one line? 

  
 Minor 

  
 OK 






Comments on file 'trunk/src/dk/netarkivet/common/utils/MockFreeSpaceProvider.java', revision 892


  
 Lines 

  
 Description 

  
 Classification 

  
 Status 




  
 General 

  
 Missing subversion keys 

  
 Cosmetic 

  
 OK 




  
 General 

  
 Move to the tests/dk/netarkivet/common/utils/ 

  
 Cosmetic 

  
 OK 




IssuesFromNs60  (last edited 2010-08-16 10:24:28 by localhost)