= Review (NS-61): FR 1717: Increase crawler trap textarea size; Bug 1644: On Edit Domain page, the text field only shows 21 characters of the domainname size; FR [[#1716]] Increase size of input field, when uploading harvest templates =
|| Author || Søren ||
|| Moderator || Søren ||
|| State || Closed ||
== Objectives ==
{{{
Validate implementation of FR 1716 and 1717, and the fixing of bug 1644
}}}
== Summary ==
{{{
Review completed, followup by SVC
}}}
'''General comments''':
|| '''Description''' || '''Classification''' || '''Status''' ||


=== Comments on file 'trunk/webpages/HarvestDefinition/Definitions-edit-domain.jsp', revision 883 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| 259 || Should these not be constants in the constant class or perhaps in settings? || Cosmetic || OK ||
=== Comments on file 'trunk/webpages/HarvestDefinition/Definitions-edit-harvest-templates.jsp', revision 882 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| 104 || This hard coded constant should be put either in a Constants class or in the settings. || Cosmetic || OK ||
|| 113-114 || Again hard coded constants in the scripts ('30' and '60'). || Cosmetic || OK ||
=== Comments on file 'trunk/src/dk/netarkivet/harvester/webinterface/Constants.java', revision 883 ===
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| 125 || It would be better if it is a variable in settings instead of a constant. || Cosmetic ||REJECTED ||