NetarchiveSuite|
Size: 1899
Comment:
|
Size: 1871
Comment:
|
| Deletions are marked like this. | Additions are marked like this. |
| Line 7: | Line 7: |
| Line 10: | Line 9: |
| {{{ | {{{ |
| Line 14: | Line 13: |
| {{{ | {{{ |
| Line 20: | Line 20: |
| Line 27: | Line 26: |
| || 62-63 || There should no be two empty lines next to each other. || Cosmetic || NOTOK || || 101 || . || Cosmetic || NOTOK || || 104 || . || Cosmetic || NOTOK || || 105 || . || Cosmetic || NOTOK || || 110 || . || Cosmetic || NOTOK || || 113, 117-118, 123-124 || Bug 1650: Check that the jmx-files exists. Describe that it is not checked here, and why. || Cosmetic || NOTOK || || 363-366 || Improper method description. Does not respect the codestyle. || Cosmetic || NOTOK || || 370-373 || Improper method description. Does not respect the codestyle. || Cosmetic || NOTOK || |
|| 62-63 || There should no be two empty lines next to each other. || Cosmetic || OK || || 101 || . || Cosmetic || OK || || 104 || . || Cosmetic || OK || || 105 || . || Cosmetic || OK || || 110 || . || Cosmetic || OK || || 113, 117-118, 123-124 || Bug 1650: Check that the jmx-files exists. Describe that it is not checked here, and why. || Cosmetic || OK || || 363-366 || Improper method description. Does not respect the codestyle. || Cosmetic || OK || || 370-373 || Improper method description. Does not respect the codestyle. || Cosmetic || OK || |
Review (NS-63): Bug 1650
Author |
Jonas |
Moderator |
Jonas |
State |
Closed |
Objectives
Summary
Only cosmetic issues.
Total Time Used (Coding,Documentation,Review):
Time use (Coding,Documentation,Review) SVC: 0.5 JOLF: 0.25 HBK: 0.25
General comments:
Description |
Classification |
Status |
Comments on file 'trunk/src/dk/netarkivet/harvester/harvesting/HeritrixFiles.java', revision 888
Lines |
Description |
Classification |
Status |
62-63 |
There should no be two empty lines next to each other. |
Cosmetic |
OK |
101 |
. |
Cosmetic |
OK |
104 |
. |
Cosmetic |
OK |
105 |
. |
Cosmetic |
OK |
110 |
. |
Cosmetic |
OK |
113, 117-118, 123-124 |
Bug 1650: Check that the jmx-files exists. Describe that it is not checked here, and why. |
Cosmetic |
OK |
363-366 |
Improper method description. Does not respect the codestyle. |
Cosmetic |
OK |
370-373 |
Improper method description. Does not respect the codestyle. |
Cosmetic |
OK |
Comments on file 'trunk/src/dk/netarkivet/harvester/harvesting/JMXHeritrixController.java', revision 888
Lines |
Description |
Classification |
Status |
283 |
TODO: |
Cosmetic |
NOTOK |
287 |
"The password file '" |
Cosmetic |
NOTOK |
287-291 |
The string is only used once and a different message is thrown in IOFailure. |
Cosmetic |
NOTOK |
290 |
"Failed to read password file '" |
Cosmetic |
NOTOK |
296-300 |
The string is only used once and a different message is thrown in IOFailure. |
Cosmetic |
NOTOK |
296 |
"The access file '" |
Cosmetic |
NOTOK |
299 |
"Failled to read access file '" |
Cosmetic |
NOTOK |