Review (NS-78): Task Access 2.2: Review of ant targets related to wayback

Moderator	Colin
State	Closed

Objectives

Create ant task to build dk.netarkivet.wayback.jar containing netarchivesuite code related to wayback.
Create new ant build file to build deployable war file for wayback for prod and test environments

Total Time Used (Coding,Documentation,Review):

1,5 md
0,1 md

General comments:

Description

Classification

Status

Comments on file 'trunk/build.xml', revision 846

Lines	Description	Classification	Status
266-269	Bad indentation	Cosmetic	NOTOK
424-434	Odd indentation	Cosmetic	NOTOK

Comments on file 'trunk/wayback.build.xml', revision 846

Lines	Description	Classification	Status
3	We should explain the logic of the "warfile" target for the benefit of future maintainers - ie that we unpack the distributed wayback war file, customise it and then repack it.	Cosmetic	OK
18	Why having two variables pointing to the same directory?	Cosmetic	Rejected
64	Document reason for excludes (that these jar files are already included in wayback.war with more recent version numbers).	Cosmetic	OK