Review (NS-80): Added support for individual timeout for each batch job...
Author |
Henrik Kirk |
Moderator |
Henrik Kirk |
State |
Closed |
Objectives
970: Added support for individual timeout for each batch job implementation to differ from the standard timeout, which are currently 14 days.
Summary
Followup committed in Rev 1000 :D
Total Time Used (Coding,Documentation,Review):
2,5 md 0,3 md
General comments:
Description |
Classification |
Status |
Add batchtimeout as argument to the RunBatch tool |
Cosmetic |
OK |
Comments on file 'trunk/src/dk/netarkivet/archive/bitarchive/BitarchiveMonitor.java', revision 970
Lines |
Description |
Classification |
Status |
104-105 |
Delete unused lines |
Cosmetic |
OK |
332 |
Add to javadoc, that the timer for the batchjob starts ticking in this method |
Cosmetic |
OK |
Comments on file 'trunk/src/dk/netarkivet/viewerproxy/reporting/HarvestedUrlsForDomainBatchJob.java', revision 971
Lines |
Description |
Classification |
Status |
59 |
Check the validity of this argument |
NA |
OK |
64 |
Make a constant for this number. make it one week instead of two |
Cosmetic |
OK |
93-94 |
This ressource is not closed after its use; Add a finally clause to the try .. catch clause with the following contents: try {arcreader.close() } catch (IOException e) { log.warn("unable to close arcreader probably", e); } |
Cosmetic |
OK |
Comments on file 'trunk/src/dk/netarkivet/viewerproxy/GetDataResolver.java', revision 971
Lines |
Description |
Classification |
Status |
274 |
Replace with a constant |
Cosmetic |
OK |
Comments on file 'trunk/src/dk/netarkivet/common/utils/batch/FileBatchJob.java', revision 970
Lines |
Description |
Classification |
Status |
General |
To make this more adaptable, add a setBatchJobTimeout() method |
Cosmetic |
OK |
Comments on file 'trunk/src/dk/netarkivet/viewerproxy/LocalCDXCache.java', revision 971
Lines |
Description |
Classification |
Status |
General |
Replace TODO Write javadoc with the javadoc |
Cosmetic |
OK |
207 |
Replace with a constant |
Cosmetic |
OK |
Comments on file 'trunk/src/dk/netarkivet/archive/arcrepository/bitpreservation/FileListJob.java', revision 971
Lines |
Description |
Classification |
Status |
56 |
replace with a constant |
Cosmetic |
OK |
Comments on file 'trunk/src/dk/netarkivet/wayback/ExtractWaybackCDXBatchJob.java', revision 971
Lines |
Description |
Classification |
Status |
General |
Implement javadoc |
Cosmetic |
OK |
General |
Implement javadoc |
Cosmetic |
OK |
55 |
Add another constructor which has the wanted timeout as an argument |
Cosmetic |
OK |
59 |
Make this value a constant |
Cosmetic |
OK |
Comments on file 'trunk/src/dk/netarkivet/archive/arcrepository/bitpreservation/ChecksumJob.java', revision 971
Lines |
Description |
Classification |
Status |
54 |
This is not a reasonable default value for a checksum job that only handles a single file. Probably 15 minutes is more suitable |
Cosmetic |
OK |
Comments on file 'trunk/src/dk/netarkivet/archive/indexserver/RawMetadataCache.java', revision 971
Lines |
Description |
Classification |
Status |
168 |
Replace with a constant |
Cosmetic |
OK |
168 |
replace with l day |
Cosmetic |
OK |
Comments on file 'trunk/src/dk/netarkivet/common/utils/cdx/GetCDXRecordsBatchJob.java', revision 971
Lines |
Description |
Classification |
Status |
General |
Implement javadoc |
Cosmetic |
OK |
52-53 |
Replace with constants |
Cosmetic |
OK |
57 |
two week => one week |
Cosmetic |
OK |
57 |
Replace with constants |
Cosmetic |
OK |
Comments on file 'trunk/src/dk/netarkivet/common/utils/cdx/ExtractCDXJob.java', revision 971
Lines |
Description |
Classification |
Status |
75, 89 |
Replace with constants |
Cosmetic |
OK |
75, 89 |
Why do we have two timeouts here? remove the two week constant |
Cosmetic |
OK |