= Review (NS-85): FR 1298: Set JMX timeout for system overview pages = || Author || Kåre || || Moderator || Kåre || || State || Closed || == Objectives == {{{ All important changes are in RmiProxyConnectionFactory. Everything else is just unimportant cleanups. Note: Some source files are added as patches, since crucible can't handle the renaming from non-trunk name that was the last commit. }}} == Summary == {{{ KFC follows up }}} '''Total Time Used (Coding,Documentation,Review)''': {{{ Time used: KFC: 1½md SVC: ½md }}} '''General comments''': || '''Description''' || '''Classification''' || '''Status''' || === Comments on file 'src/dk/netarkivet/monitor/jmx/RmiProxyConnectionFactory.java', revision 2:T === || '''Lines''' || '''Description''' || '''Classification''' || '''Status''' || || 100 || Make into setting now || Minor || OK || || 132 || Add to javadoc: ensures that we only do one connect() operation at a time || Cosmetic || OK || || 163 || Add javadoc || Cosmetic || OK ||