Differences between revisions 6 and 7
Revision 6 as of 2008-08-28 11:51:06
Size: 2129
Editor: EldZierau
Comment:
Revision 7 as of 2010-08-16 10:24:31
Size: 2143
Editor: localhost
Comment: converted to 1.6 markup
Deletions are marked like this. Additions are marked like this.
Line 9: Line 9:
For details on how to do a review, see ["Code Review Process"].
||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Class/Page]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Version]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Lines/parts]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Task]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Author(s)]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Reviewer(s)]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Review date]''' ||<bgcolor="#dddddd">'''[:Code Review Process#TableFilledReviewsOverview:Follow-up]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Done]''' ||
||[:CommonDistributeArcrepositoryARCLookupReview:dk.netarkivet.common.distribute.arcrepository.ARCLookup] ||212 ||147-150 ||Bug #1079 ||LC || || || || ||
||[:HarvesterHarvestingJMXHeritrixControllerReview:dk.netarkivet.harvester.harvesting.JMXHeritrixController]||212||78-79,138-139,236,316-334||Bug #1182||LC|| || || || ||
||[:CommonDistributeChannelsReview:dk.netarkivet.common.distribute.Channels.java]|| || ||Bug #555||SVC|| || || || ||
||[:CommonDistributeJMSConnectionReview:dk.netarkivet.common.distribute.JMSConnection]|| || ||Bug #555||SVC|| || || || ||
||[:CommonDistributeJMSConnectionSunMQReview:dk.netarkivet.common.distribute.JMSConnectionSuMQ]|| || ||Bug #555||SVC|| || || || ||
For details on how to do a review, see [[Code Review Process]].
||<bgcolor="#dddddd" style="text-align: center;">'''[[Code Review Process#TableFilledReviewsOverview|Class/Page]]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[[Code Review Process#TableFilledReviewsOverview|Version]]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[[Code Review Process#TableFilledReviewsOverview|Lines/parts]]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[[Code Review Process#TableFilledReviewsOverview|Task]]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[[Code Review Process#TableFilledReviewsOverview|Author(s)]]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[[Code Review Process#TableFilledReviewsOverview|Reviewer(s)]]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[[Code Review Process#TableFilledReviewsOverview|Review date]]''' ||<bgcolor="#dddddd">'''[[Code Review Process#TableFilledReviewsOverview|Follow-up]]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[[Code Review Process#TableFilledReviewsOverview|Done]]''' ||
||[[CommonDistributeArcrepositoryARCLookupReview|dk.netarkivet.common.distribute.arcrepository.ARCLookup]] ||212 ||147-150 ||Bug #1079 ||LC || || || || ||
||[[HarvesterHarvestingJMXHeritrixControllerReview|dk.netarkivet.harvester.harvesting.JMXHeritrixController]]||212||78-79,138-139,236,316-334||Bug #1182||LC|| || || || ||
||[[CommonDistributeChannelsReview|dk.netarkivet.common.distribute.Channels.java]]|| || ||Bug #555||SVC|| || || || ||
||[[CommonDistributeJMSConnectionReview|dk.netarkivet.common.distribute.JMSConnection]]|| || ||Bug #555||SVC|| || || || ||
||[[CommonDistributeJMSConnectionSunMQReview|dk.netarkivet.common.distribute.JMSConnectionSuMQ]]|| || ||Bug #555||SVC|| || || || ||

Reviews in iteration 33

Review of code should happen immediately after coding for a task or bug is done, so as little as possible is based on unreviewed code.

If the reviewer for some reason cannot be contacted within a reasonable timeframe, another reviewer should be chosen.

We don't register review time as separate from coding time.

For details on how to do a review, see Code Review Process.

Class/Page

Version

Lines/parts

Task

Author(s)

Reviewer(s)

Review date

Follow-up

Done

dk.netarkivet.common.distribute.arcrepository.ARCLookup

212

147-150

Bug #1079

LC

dk.netarkivet.harvester.harvesting.JMXHeritrixController

212

78-79,138-139,236,316-334

Bug #1182

LC

dk.netarkivet.common.distribute.Channels.java

Bug #555

SVC

dk.netarkivet.common.distribute.JMSConnection

Bug #555

SVC

dk.netarkivet.common.distribute.JMSConnectionSuMQ

Bug #555

SVC

Iteration33ReviewsOverview (last edited 2010-08-16 10:24:31 by localhost)