⇤ ← Revision 1 as of 2008-01-11 13:44:13
2198
Comment:
|
1918
|
Deletions are marked like this. | Additions are marked like this. |
Line 2: | Line 2: |
Line 11: | Line 10: |
For details on how to do a review, see [:Code_Review_Process:Code Review Process]. | For details on how to do a review, see ["Code Review Process"]. |
Line 13: | Line 12: |
|| <Link to code review page for class/JSP-page named with java path name, f.ex. dk.netarkivet.harvestdefinition.JobDAO> || <SVN version of code being reviewed> || <Lines/parts to review> || <Reference to task caused the code changes that are being reviewed as for example a bugs, a feature request or an assignment> || <Initials of author of changes in code> || <Initials of reviewer in code review> || <Date that review was held on form YYYY/MM/DD> || <Initials of person to do follow-up on code review> || <Must be either [[BR]] '''''Ok''''' (no further action), [[BR]] '''''Ok w/postponed''''' (no further action within this iteration, but includes postpones to be done later)> || | ||[[CommonDistributeArcrepositoryARCLookupReview][dk.netarkivet.common.distribute.arcrepository.ARCLookup]] ||212||147-150 ||Bug #1079||LC || || <Date that review was held on form YYYY/MM/DD> || <Initials of person to do follow-up on code review> || <Must be either [[BR]] '''''Ok''''' (no further action), [[BR]] '''''Ok w/postponed''''' (no further action within this iteration, but includes postpones to be done later)> || |
Reviews in iteration 33
Review of code should happen immediately after coding for a task or bug is done, so as little as possible is based on unreviewed code.
If the reviewer for some reason cannot be contacted within a reasonable timeframe, another reviewer should be chosen.
We don't register review time as separate from coding time.
For details on how to do a review, see ["Code Review Process"].
[:Code Review Process#TableFilledReviewsOverview:Class/Page] |
[:Code Review Process#TableFilledReviewsOverview:Version] |
[:Code Review Process#TableFilledReviewsOverview:Parts/lines] |
[:Code Review Process#TableFilledReviewsOverview:Task] |
[:Code Review Process#TableFilledReviewsOverview:Author(s)] |
[:Code Review Process#TableFilledReviewsOverview:Reviewer(s)] |
[:Code Review Process#TableFilledReviewsOverview:Review date] |
[:Code Review Process#TableFilledReviewsOverview:Follow-up] |
[:Code Review Process#TableFilledReviewsOverview:Done] |
212 |
147-150 |
Bug #1079 |
LC |
|
<Date that review was held on form YYYY/MM/DD> |
<Initials of person to do follow-up on code review> |
<Must be either BR Ok (no further action), BR Ok w/postponed (no further action within this iteration, but includes postpones to be done later)> |