Diff for "Iteration33ReviewsOverview"

Differences between revisions 1 and 7 (spanning 6 versions)

Reviews in iteration 33

Review of code should happen immediately after coding for a task or bug is done, so as little as possible is based on unreviewed code.

If the reviewer for some reason cannot be contacted within a reasonable timeframe, another reviewer should be chosen.

We don't register review time as separate from coding time.

For details on how to do a review, see Code Review Process.

Class/Page	Version	Lines/parts	Task	Author(s)	Reviewer(s)	Review date	Follow-up	Done
dk.netarkivet.common.distribute.arcrepository.ARCLookup	212	147-150	Bug #1079	LC
dk.netarkivet.harvester.harvesting.JMXHeritrixController	212	78-79,138-139,236,316-334	Bug #1182	LC
dk.netarkivet.common.distribute.Channels.java			Bug #555	SVC
dk.netarkivet.common.distribute.JMSConnection			Bug #555	SVC
dk.netarkivet.common.distribute.JMSConnectionSuMQ			Bug #555	SVC

-  ⇤ ← Revision 1 as of 2008-01-11 13:44:13 → 
  Size: 2198
  Editor: EldZierau
  Comment:
+   ← Revision 7 as of 2010-08-16 10:24:31 → ⇥
  Size: 2143
  Editor: localhost
  Comment: converted to 1.6 markup
-Deletions are marked like this.
+Additions are marked like this.
 Line 1:
-#acl NetarkivetGroup:read,write,delete,revert,admin All:
-Line 11:
+Line 9:
-For details on how to do a review, see [:Code_Review_Process:Code Review Process].
||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Class/Page]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Version]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Parts/lines]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Task]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Author(s)]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Reviewer(s)]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Review date]''' ||<bgcolor="#dddddd">'''[:Code Review Process#TableFilledReviewsOverview:Follow-up]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Done]''' ||
|| <Link to code review page for class/JSP-page named with java path name, f.ex. dk.netarkivet.harvestdefinition.JobDAO> || <SVN version of code being reviewed> || <Lines/parts to review> || <Reference to task caused the code changes that are being reviewed as for example a bugs, a feature request or an assignment> || <Initials of author of changes in code> || <Initials of reviewer in code review> ||    <Date that review was held on form YYYY/MM/DD> || <Initials of person to do follow-up on code review> || <Must be either [[BR]] '''''Ok''''' (no further action), [[BR]] '''''Ok w/postponed''''' (no further action within this iteration, but includes postpones to be done later)> ||
+For details on how to do a review, see [[Code Review Process]].
||<bgcolor="#dddddd" style="text-align: center;">'''[[Code Review Process#TableFilledReviewsOverview|Class/Page]]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[[Code Review Process#TableFilledReviewsOverview|Version]]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[[Code Review Process#TableFilledReviewsOverview|Lines/parts]]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[[Code Review Process#TableFilledReviewsOverview|Task]]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[[Code Review Process#TableFilledReviewsOverview|Author(s)]]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[[Code Review Process#TableFilledReviewsOverview|Reviewer(s)]]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[[Code Review Process#TableFilledReviewsOverview|Review date]]''' ||<bgcolor="#dddddd">'''[[Code Review Process#TableFilledReviewsOverview|Follow-up]]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[[Code Review Process#TableFilledReviewsOverview|Done]]''' ||
||[[CommonDistributeArcrepositoryARCLookupReview|dk.netarkivet.common.distribute.arcrepository.ARCLookup]] ||212 ||147-150 ||Bug #1079 ||LC || || || || ||
||[[HarvesterHarvestingJMXHeritrixControllerReview|dk.netarkivet.harvester.harvesting.JMXHeritrixController]]||212||78-79,138-139,236,316-334||Bug #1182||LC|| || || || ||
||[[CommonDistributeChannelsReview|dk.netarkivet.common.distribute.Channels.java]]|| || ||Bug #555||SVC|| || || || ||
||[[CommonDistributeJMSConnectionReview|dk.netarkivet.common.distribute.JMSConnection]]|| || ||Bug #555||SVC|| || || || ||
||[[CommonDistributeJMSConnectionSunMQReview|dk.netarkivet.common.distribute.JMSConnectionSuMQ]]|| || ||Bug #555||SVC|| || || || ||